Page MenuHomePhabricator
Differential D14036

[native][web] Show version unsupported modal when received use_new_flow on logout
ClosedPublic
Actions

Authored by bartek on Mon, Nov 25, 3:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 3:23 AM
Unknown Object (File)
Fri, Dec 20, 7:07 PM
Unknown Object (File)
Mon, Dec 16, 1:38 PM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Fri, Dec 13, 6:28 AM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on…
Summary

Address ENG-9718.
Display "version unsupported" message upon logout, when use_new_flow response is received

Depends on D14035

Test Plan

Mocked Identity logout response. I was visually logged out and modal appeared.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mon, Nov 25, 3:52 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Nov 25, 3:52 AM
bartek added a child revision: D14037: [native] Show version unsupported when opened QR screen.Mon, Nov 25, 3:54 AM
Harbormaster completed remote builds in B32810: Diff 45997.Mon, Nov 25, 4:41 AM
bartek published this revision for review.Mon, Nov 25, 5:09 AM
kamil accepted this revision.Tue, Nov 26, 2:13 AM
kamil added inline comments.
native/profile/profile-screen.react.js
579–581 ↗(On Diff #45997)

I would memoize this object

web/settings/account-settings.react.js
48–53 ↗(On Diff #45997)

I would use React.useMemo instead of React.useCallback and memorize entire useLogOut param

This revision is now accepted and ready to land.Tue, Nov 26, 2:13 AM
bartek added inline comments.Fri, Nov 29, 3:03 AM
web/settings/account-settings.react.js
48–53 ↗(On Diff #45997)

Good idea, thank you

bartek updated this revision to Diff 46128.Fri, Nov 29, 3:10 AM

Apply hooks suggestion

Harbormaster completed remote builds in B32897: Diff 46128.Fri, Nov 29, 3:30 AM
Closed by commit rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on… (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMa9ed6112cc26: [native][web] Show version unsupported modal when received use_new_flow on….
ashoat added inline comments.Mon, Dec 2, 10:10 AM
native/profile/profile-screen.react.js
579–581 ↗(On Diff #45997)

This feedback doesn't seem to have been addressed

bartek mentioned this in D14078: [native] Memoize logOutOptions.Wed, Dec 4, 7:44 AM
bartek mentioned this in rCOMM58cdeac3bb64: [native] Memoize logOutOptions.Fri, Dec 6, 4:45 AM

Revision Contents
Changeset List

PathSize
native/
profile/
7 lines
web/
settings/
13 lines

Diff 46128

View Options

native/profile/profile-screen.react.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...