Page MenuHomePhabricator
Differential D14051

[native] Rename the QR sign-in navigator
ClosedPublic
Actions

Authored by tomek on Nov 26 2024, 8:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2025, 3:06 AM
Unknown Object (File)
Mar 5 2025, 3:06 AM
Unknown Object (File)
Mar 5 2025, 3:06 AM
Unknown Object (File)
Mar 5 2025, 3:06 AM
Unknown Object (File)
Mar 5 2025, 3:06 AM
Unknown Object (File)
Mar 2 2025, 2:01 AM
Unknown Object (File)
Feb 6 2025, 8:43 PM
Unknown Object (File)
Feb 6 2025, 8:43 PM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
kamil
angelika
bartek
Commits
rCOMM39eccd8276bd: [native] Rename the QR sign-in navigator
Summary

This navigator will also handle the restore flow so it has to be renamed.

Depends on D13905

Test Plan

Flow. Tested in combination with the rest of the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
4 lines
navigation/
8 lines
10 lines
qr-code/
4 lines
sign-in-navigator.react.js
qr-code-sign-in-navigator.react.js
25 lines

Diff 46182

View Options

native/account/logged-out-modal.react.js

Show All 39 Lines
import { useRatchetingKeyboardHeight } from '../keyboard/animated-keyboard.js'; import { useRatchetingKeyboardHeight } from '../keyboard/animated-keyboard.js';
import { createIsForegroundSelector } from '../navigation/nav-selectors.js'; import { createIsForegroundSelector } from '../navigation/nav-selectors.js';
import { NavContext } from '../navigation/navigation-context.js'; import { NavContext } from '../navigation/navigation-context.js';
import type { RootNavigationProp } from '../navigation/root-navigator.react.js'; import type { RootNavigationProp } from '../navigation/root-navigator.react.js';
import { import {
type NavigationRoute, type NavigationRoute,
LoggedOutModalRouteName, LoggedOutModalRouteName,
RegistrationRouteName, RegistrationRouteName,
QRCodeSignInNavigatorRouteName, SignInNavigatorRouteName,
} from '../navigation/route-names.js'; } from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { derivedDimensionsInfoSelector } from '../selectors/dimensions-selectors.js'; import { derivedDimensionsInfoSelector } from '../selectors/dimensions-selectors.js';
import { splashStyleSelector } from '../splash.js'; import { splashStyleSelector } from '../splash.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
import { AnimatedView } from '../types/styles.js'; import { AnimatedView } from '../types/styles.js';
import EthereumLogo from '../vectors/ethereum-logo.react.js'; import EthereumLogo from '../vectors/ethereum-logo.react.js';
▲ Show 20 Lines • Show All 366 Lines • ▼ Show 20 Linesfunction LoggedOutModal(props: Props) {
}, [combinedSetMode]); }, [combinedSetMode]);
const onPressLogIn = React.useCallback(() => { const onPressLogIn = React.useCallback(() => {
combinedSetMode('log-in'); combinedSetMode('log-in');
}, [combinedSetMode]); }, [combinedSetMode]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onPressQRCodeSignIn = React.useCallback(() => { const onPressQRCodeSignIn = React.useCallback(() => {
navigate(QRCodeSignInNavigatorRouteName); navigate(SignInNavigatorRouteName);
}, [navigate]); }, [navigate]);
const onPressNewRegister = React.useCallback(() => { const onPressNewRegister = React.useCallback(() => {
navigate(RegistrationRouteName); navigate(RegistrationRouteName);
}, [navigate]); }, [navigate]);
const opacityStyle = useAnimatedStyle(() => ({ const opacityStyle = useAnimatedStyle(() => ({
opacity: getPanelOpacity(modeValue.value, finishResettingToPrompt), opacity: getPanelOpacity(modeValue.value, finishResettingToPrompt),
▲ Show 20 Lines • Show All 218 Lines • Show Last 20 Lines
View Options

native/navigation/root-navigator.react.js

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Linesimport {
type ScreenParamList, type ScreenParamList,
type RootParamList, type RootParamList,
TermsAndPrivacyRouteName, TermsAndPrivacyRouteName,
RegistrationRouteName, RegistrationRouteName,
InviteLinkModalRouteName, InviteLinkModalRouteName,
InviteLinkNavigatorRouteName, InviteLinkNavigatorRouteName,
CommunityCreationRouteName, CommunityCreationRouteName,
RolesNavigatorRouteName, RolesNavigatorRouteName,
QRCodeSignInNavigatorRouteName, SignInNavigatorRouteName,
UserProfileBottomSheetNavigatorRouteName, UserProfileBottomSheetNavigatorRouteName,
KeyserverSelectionBottomSheetRouteName, KeyserverSelectionBottomSheetRouteName,
ConnectFarcasterBottomSheetRouteName, ConnectFarcasterBottomSheetRouteName,
TagFarcasterChannelNavigatorRouteName, TagFarcasterChannelNavigatorRouteName,
CreateMissingSIWEBackupMessageRouteName, CreateMissingSIWEBackupMessageRouteName,
RestoreSIWEBackupRouteName, RestoreSIWEBackupRouteName,
LinkedDevicesBottomSheetRouteName, LinkedDevicesBottomSheetRouteName,
} from './route-names.js'; } from './route-names.js';
Show All 12 Lines
import SubchannelsListModal from '../chat/subchannels-list-modal.react.js'; import SubchannelsListModal from '../chat/subchannels-list-modal.react.js';
import CommunityCreationNavigator from '../community-creation/community-creation-navigator.react.js'; import CommunityCreationNavigator from '../community-creation/community-creation-navigator.react.js';
import TagFarcasterChannelNavigator from '../community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js'; import TagFarcasterChannelNavigator from '../community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js';
import ConnectFarcasterBottomSheet from '../components/connect-farcaster-bottom-sheet.react.js'; import ConnectFarcasterBottomSheet from '../components/connect-farcaster-bottom-sheet.react.js';
import InviteLinksNavigator from '../invite-links/invite-links-navigator.react.js'; import InviteLinksNavigator from '../invite-links/invite-links-navigator.react.js';
import CustomServerModal from '../profile/custom-server-modal.react.js'; import CustomServerModal from '../profile/custom-server-modal.react.js';
import KeyserverSelectionBottomSheet from '../profile/keyserver-selection-bottom-sheet.react.js'; import KeyserverSelectionBottomSheet from '../profile/keyserver-selection-bottom-sheet.react.js';
import LinkedDevicesBottomSheet from '../profile/linked-devices-bottom-sheet.react.js'; import LinkedDevicesBottomSheet from '../profile/linked-devices-bottom-sheet.react.js';
import QRCodeSignInNavigator from '../qr-code/qr-code-sign-in-navigator.react.js'; import SignInNavigator from '../qr-code/sign-in-navigator.react.js';
import RolesNavigator from '../roles/roles-navigator.react.js'; import RolesNavigator from '../roles/roles-navigator.react.js';
import UserProfileBottomSheetNavigator from '../user-profile/user-profile-bottom-sheet-navigator.react.js'; import UserProfileBottomSheetNavigator from '../user-profile/user-profile-bottom-sheet-navigator.react.js';
enableScreens(); enableScreens();
export type RootNavigationHelpers<ParamList: ParamListBase = ParamListBase> = { export type RootNavigationHelpers<ParamList: ParamListBase = ParamListBase> = {
...$Exact<StackNavigationHelpers<ParamList>>, ...$Exact<StackNavigationHelpers<ParamList>>,
...RootRouterExtraNavigationHelpers, ...RootRouterExtraNavigationHelpers,
▲ Show 20 Lines • Show All 119 Lines • ▼ Show 20 Lines <Root.Navigator screenOptions={defaultScreenOptions}>
options={disableGesturesScreenOptions} options={disableGesturesScreenOptions}
/> />
<Root.Screen <Root.Screen
name={RegistrationRouteName} name={RegistrationRouteName}
component={RegistrationNavigator} component={RegistrationNavigator}
options={disableGesturesScreenOptions} options={disableGesturesScreenOptions}
/> />
<Root.Screen <Root.Screen
name={QRCodeSignInNavigatorRouteName} name={SignInNavigatorRouteName}
component={QRCodeSignInNavigator} component={SignInNavigator}
options={disableGesturesScreenOptions} options={disableGesturesScreenOptions}
/> />
<Root.Screen <Root.Screen
name={CommunityCreationRouteName} name={CommunityCreationRouteName}
component={CommunityCreationNavigator} component={CommunityCreationNavigator}
/> />
<Root.Screen name={AppRouteName} component={AppNavigator} /> <Root.Screen name={AppRouteName} component={AppNavigator} />
<Root.Screen <Root.Screen
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines
View Options

native/navigation/route-names.js

Show First 20 Lines • Show All 143 Lines • ▼ Show 20 Lines
export const AvatarSelectionRouteName = 'AvatarSelection'; export const AvatarSelectionRouteName = 'AvatarSelection';
export const EmojiAvatarSelectionRouteName = 'EmojiAvatarSelection'; export const EmojiAvatarSelectionRouteName = 'EmojiAvatarSelection';
export const RegistrationUserAvatarCameraModalRouteName = export const RegistrationUserAvatarCameraModalRouteName =
'RegistrationUserAvatarCameraModal'; 'RegistrationUserAvatarCameraModal';
export const RegistrationTermsRouteName = 'RegistrationTerms'; export const RegistrationTermsRouteName = 'RegistrationTerms';
export const RolesNavigatorRouteName = 'RolesNavigator'; export const RolesNavigatorRouteName = 'RolesNavigator';
export const CommunityRolesScreenRouteName = 'CommunityRolesScreen'; export const CommunityRolesScreenRouteName = 'CommunityRolesScreen';
export const CreateRolesScreenRouteName = 'CreateRolesScreen'; export const CreateRolesScreenRouteName = 'CreateRolesScreen';
export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator'; export const SignInNavigatorRouteName = 'SignInNavigator';
export const QRCodeScreenRouteName = 'QRCodeScreen'; export const QRCodeScreenRouteName = 'QRCodeScreen';
export const UserProfileBottomSheetNavigatorRouteName = export const UserProfileBottomSheetNavigatorRouteName =
'UserProfileBottomSheetNavigator'; 'UserProfileBottomSheetNavigator';
export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet'; export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';
export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal'; export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';
export const KeyserverSelectionListRouteName = 'KeyserverSelectionList'; export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';
export const AddKeyserverRouteName = 'AddKeyserver'; export const AddKeyserverRouteName = 'AddKeyserver';
export const KeyserverSelectionBottomSheetRouteName = export const KeyserverSelectionBottomSheetRouteName =
Show All 27 Linesexport type RootParamList = {
+TermsAndPrivacyModal: TermsAndPrivacyModalParams, +TermsAndPrivacyModal: TermsAndPrivacyModalParams,
+SubchannelsListModal: SubchannelListModalParams, +SubchannelsListModal: SubchannelListModalParams,
+MessageReactionsModal: MessageReactionsModalParams, +MessageReactionsModal: MessageReactionsModalParams,
+Registration: void, +Registration: void,
+CommunityCreation: void, +CommunityCreation: void,
+InviteLinkModal: InviteLinkModalParams, +InviteLinkModal: InviteLinkModalParams,
+InviteLinkNavigator: InviteLinksNavigatorParams, +InviteLinkNavigator: InviteLinksNavigatorParams,
+RolesNavigator: void, +RolesNavigator: void,
+QRCodeSignInNavigator: void, +SignInNavigator: void,
+UserProfileBottomSheetNavigator: void, +UserProfileBottomSheetNavigator: void,
+TunnelbrokerMenu: void, +TunnelbrokerMenu: void,
+KeyserverSelectionBottomSheet: KeyserverSelectionBottomSheetParams, +KeyserverSelectionBottomSheet: KeyserverSelectionBottomSheetParams,
+LinkedDevicesBottomSheet: LinkedDevicesBottomSheetParams, +LinkedDevicesBottomSheet: LinkedDevicesBottomSheetParams,
+ConnectFarcasterBottomSheet: void, +ConnectFarcasterBottomSheet: void,
+TagFarcasterChannelNavigator: void, +TagFarcasterChannelNavigator: void,
+CreateMissingSIWEBackupMessage: void, +CreateMissingSIWEBackupMessage: void,
+RestoreSIWEBackup: RestoreSIWEBackupParams, +RestoreSIWEBackup: RestoreSIWEBackupParams,
▲ Show 20 Lines • Show All 123 Lines • ▼ Show 20 Linesexport type RolesParamList = {
+CreateRolesScreen: CreateRolesScreenParams, +CreateRolesScreen: CreateRolesScreenParams,
}; };
export type TagFarcasterChannelParamList = { export type TagFarcasterChannelParamList = {
+TagFarcasterChannel: TagFarcasterChannelParams, +TagFarcasterChannel: TagFarcasterChannelParams,
+TagFarcasterChannelByName: TagFarcasterChannelByNameParams, +TagFarcasterChannelByName: TagFarcasterChannelByNameParams,
}; };
export type QRCodeSignInParamList = { export type SignInParamList = {
+QRCodeScreen: void, +QRCodeScreen: void,
}; };
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
...ProfileParamList, ...ProfileParamList,
...CalendarParamList, ...CalendarParamList,
...CommunityDrawerParamList, ...CommunityDrawerParamList,
...RegistrationParamList, ...RegistrationParamList,
...InviteLinkParamList, ...InviteLinkParamList,
...CommunityCreationParamList, ...CommunityCreationParamList,
...RolesParamList, ...RolesParamList,
...QRCodeSignInParamList, ...SignInParamList,
...UserProfileBottomSheetParamList, ...UserProfileBottomSheetParamList,
...TagFarcasterChannelParamList, ...TagFarcasterChannelParamList,
}; };
export type NavigationRoute<RouteName: string = $Keys<ScreenParamList>> = export type NavigationRoute<RouteName: string = $Keys<ScreenParamList>> =
RouteProp<ScreenParamList, RouteName>; RouteProp<ScreenParamList, RouteName>;
export const accountModals = [ export const accountModals = [
LoggedOutModalRouteName, LoggedOutModalRouteName,
RegistrationRouteName, RegistrationRouteName,
QRCodeSignInNavigatorRouteName, SignInNavigatorRouteName,
]; ];
export const scrollBlockingModals = [ export const scrollBlockingModals = [
ImageModalRouteName, ImageModalRouteName,
MultimediaMessageTooltipModalRouteName, MultimediaMessageTooltipModalRouteName,
TextMessageTooltipModalRouteName, TextMessageTooltipModalRouteName,
ThreadSettingsMemberTooltipModalRouteName, ThreadSettingsMemberTooltipModalRouteName,
UserRelationshipTooltipModalRouteName, UserRelationshipTooltipModalRouteName,
Show All 22 Lines
View Options

native/qr-code/qr-code-screen.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Text } from 'react-native'; import { View, Text } from 'react-native';
import QRCode from 'react-native-qrcode-svg'; import QRCode from 'react-native-qrcode-svg';
import { useQRAuthContext } from 'lib/components/qr-auth-provider.react.js'; import { useQRAuthContext } from 'lib/components/qr-auth-provider.react.js';
import { qrCodeLinkURL } from 'lib/facts/links.js'; import { qrCodeLinkURL } from 'lib/facts/links.js';
import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js'; import { platformToIdentityDeviceType } from 'lib/types/identity-service-types.js';
import { getConfig } from 'lib/utils/config.js'; import { getConfig } from 'lib/utils/config.js';
import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js'; import type { SignInNavigationProp } from './sign-in-navigator.react.js';
import type { NavigationRoute } from '../navigation/route-names.js'; import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js'; import { useStyles } from '../themes/colors.js';
type QRCodeScreenProps = { type QRCodeScreenProps = {
+navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>, +navigation: SignInNavigationProp<'QRCodeScreen'>,
+route: NavigationRoute<'QRCodeScreen'>, +route: NavigationRoute<'QRCodeScreen'>,
}; };
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function QRCodeScreen(props: QRCodeScreenProps): React.Node { function QRCodeScreen(props: QRCodeScreenProps): React.Node {
const { qrData, generateQRCode } = useQRAuthContext(); const { qrData, generateQRCode } = useQRAuthContext();
React.useEffect(() => { React.useEffect(() => {
▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines
View Options

native/qr-code/qr-code-sign-in-navigator.react.js

Loading...
View Options

native/qr-code/sign-in-navigator.react.js

Loading...