Page MenuHomePhabricator

[web] Change `ConfirmLeaveThreadModal` size to `fit-content`
ClosedPublic

Authored by jacek on Apr 25 2022, 10:01 AM.
Tags
None
Referenced Files
F3373314: D3836.diff
Tue, Nov 26, 8:58 AM
Unknown Object (File)
Sun, Nov 24, 8:59 AM
Unknown Object (File)
Tue, Nov 5, 4:35 AM
Unknown Object (File)
Oct 9 2024, 7:19 PM
Unknown Object (File)
Oct 9 2024, 7:19 PM
Unknown Object (File)
Oct 9 2024, 7:19 PM
Unknown Object (File)
Oct 9 2024, 7:19 PM
Unknown Object (File)
Oct 9 2024, 7:11 PM

Details

Summary

After Modal redesign, the modal size must be set to fit-content to display it with correct size.

Before:

Screenshot_Google Chrome_2022-04-25_190226.png (404×646 px, 40 KB)

After:
Screenshot_Google Chrome_2022-04-25_190200.png (354×750 px, 37 KB)

Test Plan

Try to leave the thread in web app - the modal size should now be correct

Diff Detail

Repository
rCOMM Comm
Branch
jacek/fix-modal
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently

Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently

I tried to test all existing modals after rebasing modals redesign, and found only this (newly introduced) one. If I haven't missed anything, all others can remain unchanged

Looks good, I wonder if longer term the "right place" to put fit-content is somewhere in the CSS?

This revision is now accepted and ready to land.Apr 26 2022, 7:54 AM

revert accidental change after rebase