After Modal redesign, the modal size must be set to fit-content to display it with correct size.
Before:
After:
Differential D3836
[web] Change `ConfirmLeaveThreadModal` size to `fit-content` • jacek on Apr 25 2022, 10:01 AM. Authored by Tags None Referenced Files
Details After Modal redesign, the modal size must be set to fit-content to display it with correct size. Before: After: Try to leave the thread in web app - the modal size should now be correct
Diff Detail
Event TimelineComment Actions Are there any other modals that need this update? Adding @atul as a blocking reviewer to make sure he sees this as he's been cleaning up some modals recently Comment Actions I tried to test all existing modals after rebasing modals redesign, and found only this (newly introduced) one. If I haven't missed anything, all others can remain unchanged Comment Actions Looks good, I wonder if longer term the "right place" to put fit-content is somewhere in the CSS? |