Page MenuHomePhabricator
Differential D3896

[refactor] [web] [ENG-530] rename prop from positioning to position
AbandonedPublic
Actions

Authored by atul on May 3 2022, 5:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 9:07 AM
Unknown Object (File)
Sun, Nov 10, 9:08 PM
Unknown Object (File)
Sat, Nov 9, 2:42 PM
Unknown Object (File)
Sat, Nov 9, 12:55 PM
Unknown Object (File)
Mon, Oct 28, 7:32 AM
Unknown Object (File)
Oct 20 2024, 2:58 PM
Unknown Object (File)
Oct 19 2024, 1:19 PM
Unknown Object (File)
Oct 19 2024, 1:19 PM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
ashoat
• jacek
tomek
• benschac
Summary

Change prop name. Position sounds a bit more correct than positioning

Test Plan

N/A flow should run without any error.

Diff Detail

Repository
rCOMM Comm
Branch
inline-sidebar-web-and-native-ENG-530
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.May 3 2022, 5:05 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 3 2022, 5:05 AM
• benschac updated this revision to Diff 12164.May 3 2022, 5:06 AM

change variable name

• benschac added a parent revision: D3895: [web] [chore] [ENG-530] style inline sidebar.May 3 2022, 5:07 AM
Harbormaster completed remote builds in B8732: Diff 12163.May 3 2022, 5:09 AM
Harbormaster completed remote builds in B8733: Diff 12164.May 3 2022, 5:13 AM
• benschac requested review of this revision.May 3 2022, 5:13 AM
ashoat accepted this revision.May 3 2022, 9:32 AM

Do you think there's a risk of confusion with CSS position?

This revision is now accepted and ready to land.May 3 2022, 9:32 AM
• benschac added a comment.May 3 2022, 10:13 AM
In D3896#108991, @ashoat wrote:

Do you think there's a risk of confusion with CSS position?

I don't personally. We're talking about completely different contexts. I think it's fine. Curious if anyone else on the team has concern.

atul commandeered this revision.Jul 14 2022, 10:00 AM
atul edited reviewers, added: • benschac; removed: atul.

I think we can abandon this to clear "Waiting on Authors" queue?

atul abandoned this revision.Jul 14 2022, 10:01 AM

If anyone feels strongly that this change should be made, I'm happy to re-open the diff and land. Personally think that the previous language is fine

Revision Contents
Changeset List

Diff 12163

View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/inline-sidebar.react.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...