Page MenuHomePhabricator
Differential D3905

[services] Blob - rename docker to scripts
AbandonedPublic
Actions

Authored by • karol on May 4 2022, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 9:08 AM
Unknown Object (File)
Nov 19 2024, 2:09 PM
Unknown Object (File)
Nov 18 2024, 9:57 PM
Unknown Object (File)
Nov 18 2024, 9:32 PM
Unknown Object (File)
Nov 5 2024, 3:57 PM
Unknown Object (File)
Nov 5 2024, 3:57 PM
Unknown Object (File)
Nov 5 2024, 3:55 PM
Unknown Object (File)
Oct 24 2024, 10:38 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• jim
tomek

Details

Reviewers
tomek
ashoat
• jim
Summary

Depends on D3904

When refactoring, @jimpo renamed scripts to docker. This solution is not the best as these scripts are copied twice:
https://github.com/CommE2E/comm/blob/c7fdc0b4154259b9a0f365ede281908f2479715a/services/backup/Dockerfile#L16
https://github.com/CommE2E/comm/blob/c7fdc0b4154259b9a0f365ede281908f2479715a/services/backup/Dockerfile#L17

I'm renaming the folder name to scripts again so it's copied only once.
We should use the name "scripts" inside of the docker container as from its perspective these are bash scripts that should be run.
I don't see why cannot we name this folder "scripts".

Aside from personal preferences, we should lean towards a solution that is more efficient in the end of the day.

Test Plan

No real changes are applied, just moving stuff around, so services should still build and that's the test plan

cd services

yarn run-blob-service
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 4 2022, 6:19 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 4 2022, 6:19 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2022, 6:23 AM
Harbormaster failed remote builds in B8762: Diff 12208!
• karol edited the summary of this revision. (Show Details)May 4 2022, 6:44 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3904: [services] Backup - rename docker to scripts.
• karol added a subscriber: • jim.
• karol added a child revision: D3906: [services] Lib - Add scripts to lib.May 4 2022, 6:48 AM
• karol updated this revision to Diff 12221.May 4 2022, 6:55 AM

retriggering CI (failed on android)

Harbormaster completed remote builds in B8774: Diff 12221.May 4 2022, 7:48 AM
• karol requested review of this revision.May 4 2022, 7:48 AM
ashoat requested changes to this revision.May 4 2022, 11:07 AM
ashoat added a reviewer: • jim.

See comments in D3904

This revision now requires changes to proceed.May 4 2022, 11:07 AM
• karol abandoned this revision.May 6 2022, 2:39 AM

Ok so if we're going to keep the name docker and fix this some other way, then I think we can abandon this revision.

Revision Contents
Changeset List

PathSize
services/
blob/
1 line
docker/
scripts/
docker/
20 lines
23 lines
9 lines
5 lines
7 lines

Diff 12221

View Options

services/blob/Dockerfile

Loading...
View Options

services/blob/docker/build.sh

Loading...
View Options

services/blob/docker/build_server.sh

Loading...
View Options

services/blob/docker/generate.sh

Loading...
View Options

services/blob/docker/run_server.sh

Loading...
View Options

services/blob/docker/run_tests.sh

Loading...
View Options

services/blob/scripts/build.sh

Loading...
View Options

services/blob/scripts/build_server.sh

Loading...
View Options

services/blob/scripts/generate.sh

Loading...
View Options

services/blob/scripts/run_server.sh

Loading...
View Options

services/blob/scripts/run_tests.sh

Loading...