Depends on D4013
I forgot to initialize statusHolders and it resulted in crashes
Paths
| Differential D4026 Authored by • karol on May 13 2022, 2:25 AM.
Tags None Referenced Files
Details Summary Depends on D4013 I forgot to initialize statusHolders and it resulted in crashes Test Plan Run services and use grpc playground to make any call to the backup server - it crashed before but with this change it doesn't.
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 13 2022, 2:25 AM2022-05-13 02:25:32 (UTC-7) • karol edited the summary of this revision. (Show Details)May 13 2022, 2:33 AM2022-05-13 02:33:15 (UTC-7) Harbormaster completed remote builds in B9077: Diff 12623.May 13 2022, 2:45 AM2022-05-13 02:45:00 (UTC-7) Comment Actions This is an example of a diff that would not need to be submitted if you had tested more thoroughly in the initial diff. This sort of pattern extends your stack size and creates a burden for your reveiewers This revision is now accepted and ready to land.May 13 2022, 12:29 PM2022-05-13 12:29:29 (UTC-7) Comment Actions Exactly. That's why I'm pushing https://linear.app/comm/issue/ENG-1126/test-services. If we do not have a unified way of testing services, such problems will keep occurring. Closed by commit rCOMMebe601d448ef: [services] Fix reactors - Initialize status holders (authored by • karol). · Explain WhyMay 16 2022, 12:08 AM2022-05-16 00:08:42 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 12700 services/lib/src/client-base-reactors/ClientBidiReactorBase.h
services/lib/src/client-base-reactors/ClientReadReactorBase.h
services/lib/src/client-base-reactors/ClientWriteReactorBase.h
services/lib/src/server-base-reactors/ServerBidiReactorBase.h
services/lib/src/server-base-reactors/ServerReadReactorBase.h
|