Page MenuHomePhabricator

[services] Fix reactors - Initialize status holders
ClosedPublic

Authored by karol on May 13 2022, 2:25 AM.
Tags
None
Referenced Files
F5898269: D4026.id.diff
Thu, Apr 17, 11:41 AM
F5898200: D4026.id12700.diff
Thu, Apr 17, 11:40 AM
F5891484: D4026.id12623.diff
Thu, Apr 17, 7:28 AM
Unknown Object (File)
Wed, Apr 16, 12:18 AM
Unknown Object (File)
Tue, Apr 8, 4:48 PM
Unknown Object (File)
Mon, Apr 7, 3:44 AM
Unknown Object (File)
Wed, Apr 2, 2:48 AM
Unknown Object (File)
Wed, Mar 19, 9:40 PM

Details

Summary

Depends on D4013

I forgot to initialize statusHolders and it resulted in crashes

Test Plan

Run services and use grpc playground to make any call to the backup server - it crashed before but with this change it doesn't.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is an example of a diff that would not need to be submitted if you had tested more thoroughly in the initial diff. This sort of pattern extends your stack size and creates a burden for your reveiewers

This revision is now accepted and ready to land.May 13 2022, 12:29 PM

Exactly. That's why I'm pushing https://linear.app/comm/issue/ENG-1126/test-services. If we do not have a unified way of testing services, such problems will keep occurring.