Depends on D4013
I forgot to initialize statusHolders and it resulted in crashes
Details
Details
Run services and use grpc playground to make any call to the backup server - it crashed before but with this change it doesn't.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is an example of a diff that would not need to be submitted if you had tested more thoroughly in the initial diff. This sort of pattern extends your stack size and creates a burden for your reveiewers
Comment Actions
Exactly. That's why I'm pushing https://linear.app/comm/issue/ENG-1126/test-services. If we do not have a unified way of testing services, such problems will keep occurring.