Depends on D3909
Moving base reactor from both blob/backup to the mutual "lib" space.
Details
Details
- Reviewers
tomek ashoat - Commits
- rCOMM7c4d76c47918: [services] Lib - Move base reactor
No real changes are applied, just moving stuff around, so services should still build and that's the test plan
cd services yarn run-blob-service yarn run-backup-service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I don't like the lib_src folder and I'd like to move away from having a different directory structure inside vs. outside Docker if possible, see feedback in D3909
Comment Actions
This diff is just deleting files, but I still strongly believe the directory structure should be improved (see here)
Comment Actions
Is this comment still relevant? I don't understand, in other diffs, you confirmed that the current path services/lib/src is ok.
Comment Actions
It's strange that the diff with name Move base reactor only deletes the classes. I can see that the base reactor was moved in D3909, but I think it should happen here.
Comment Actions
@ashoat not sure if this still applies. If it does, please let me know. Don't want to leave this unanswered.
Comment Actions
@ashoat not sure if this still applies. If it does, please let me know. Don't want to leave this unanswered.
It's hard for me to discern the directory structure from your diffs because there are so many, so my plan since yesterday has been to wait for your current diffs to land and then review the directory structure. I'll create a task with my feedback shortly