Depends on D3951
There is some mutual code in DatabaseManagers across services. I think we can create a parent class that includes it.
Differential D3956 Authored by • karol on May 6 2022, 3:24 PM.
Details
Summary Depends on D3951 There is some mutual code in DatabaseManagers across services. I think we can create a parent class that includes it. Test Plan cd services yarn run-local-cloud yarn test-backup-service-dev-mode yarn test-blob-service-dev-mode
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 6 2022, 3:24 PM2022-05-06 15:24:53 (UTC+0) • karol edited the summary of this revision. (Show Details)May 6 2022, 3:26 PM2022-05-06 15:26:55 (UTC+0) Harbormaster completed remote builds in B8868: Diff 12364.May 6 2022, 3:31 PM2022-05-06 15:31:15 (UTC+0) Harbormaster failed remote builds in B8896: Diff 12400!May 9 2022, 9:15 AM2022-05-09 09:15:58 (UTC+0) Harbormaster completed remote builds in B8908: Diff 12412.May 9 2022, 10:02 AM2022-05-09 10:02:52 (UTC+0) • karol added a child revision: D3970: [services] Add hasEnvFlag.May 9 2022, 3:30 PM2022-05-09 15:30:24 (UTC+0) Comment Actions Adding Ashoat to the review since Tomek is absent. I don't want to put too much on Ashoat's shoulders so if there's anyone else on the team who could review this, please, let me know. This revision is now accepted and ready to land.May 10 2022, 2:21 PM2022-05-10 14:21:37 (UTC+0) Closed by commit rCOMMfed007a357a3: [services] Lib - Add Base Database Manager. · Explain WhyMay 10 2022, 2:31 PM2022-05-10 14:31:36 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 12515 |