Page MenuHomePhabricator
Differential D3956

[services] Lib - Add Base Database Manager
ClosedPublic
Actions

Authored by • karol on May 6 2022, 8:24 AM.
Tags
None
Referenced Files
F3267093: D3956.id12364.diff
Sat, Nov 16, 2:32 AM
F3263815: D3956.id12412.diff
Sat, Nov 16, 12:18 AM
F3262036: D3956.diff
Fri, Nov 15, 11:32 PM
Unknown Object (File)
Thu, Nov 7, 4:16 PM
Unknown Object (File)
Tue, Nov 5, 3:32 PM
Unknown Object (File)
Oct 13 2024, 2:20 PM
Unknown Object (File)
Oct 13 2024, 2:20 PM
Unknown Object (File)
Oct 13 2024, 2:20 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMMfed007a357a3: [services] Lib - Add Base Database Manager
Summary

Depends on D3951

There is some mutual code in DatabaseManagers across services. I think we can create a parent class that includes it.

Test Plan
cd services
yarn run-local-cloud
yarn test-backup-service-dev-mode
yarn test-blob-service-dev-mode

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.May 6 2022, 8:24 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 6 2022, 8:24 AM
• karol edited the summary of this revision. (Show Details)May 6 2022, 8:26 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3951: [services] Lib - Introduce Global Tools.
Harbormaster completed remote builds in B8868: Diff 12364.May 6 2022, 8:31 AM
• karol requested review of this revision.May 6 2022, 8:31 AM
• karol planned changes to this revision.May 9 2022, 2:07 AM
• karol updated this revision to Diff 12400.May 9 2022, 2:10 AM

updater

Harbormaster failed remote builds in B8896: Diff 12400!May 9 2022, 2:15 AM
• karol planned changes to this revision.May 9 2022, 2:23 AM
• karol updated this revision to Diff 12412.May 9 2022, 2:35 AM

fix ci

Harbormaster completed remote builds in B8908: Diff 12412.May 9 2022, 3:02 AM
• karol added a child revision: D3970: [services] Add hasEnvFlag.May 9 2022, 8:30 AM
• karol added a reviewer: ashoat.May 10 2022, 6:48 AM

Adding Ashoat to the review since Tomek is absent. I don't want to put too much on Ashoat's shoulders so if there's anyone else on the team who could review this, please, let me know.

ashoat accepted this revision.May 10 2022, 7:21 AM

Looks good

This revision is now accepted and ready to land.May 10 2022, 7:21 AM
Closed by commit rCOMMfed007a357a3: [services] Lib - Add Base Database Manager (authored by • karol). · Explain WhyMay 10 2022, 7:31 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMfed007a357a3: [services] Lib - Add Base Database Manager.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
30 lines
31 lines
blob/
src/
31 lines
31 lines
lib/
src/
backup/
src/
DatabaseManagerBase.h
DatabaseManager.h
26 lines
lib/
src/
45 lines

Diff 12515

View Options

services/backup/src/DatabaseManager.h

Loading...
View Options

services/backup/src/DatabaseManager.cpp

Loading...
View Options

services/blob/src/DatabaseManager.h

Loading...
View Options

services/blob/src/DatabaseManager.cpp

Loading...
View Options

services/lib/src/DatabaseManagerBase.h

Loading...
View Options

services/lib/src/DatabaseManagerBase.cpp

Loading...