Page MenuHomePhabricator
Differential D3913

[services] Lib - Move client base reactors
ClosedPublic
Actions

Authored by • karol on May 4 2022, 6:22 AM.
Tags
None
Referenced Files
F5901350: D3913.id12466.diff
Thu, Apr 17, 12:39 PM
F5896841: D3913.id12441.diff
Thu, Apr 17, 11:14 AM
F5894270: D3913.id12407.diff
Thu, Apr 17, 10:13 AM
F5889845: D3913.id12218.diff
Thu, Apr 17, 5:27 AM
Unknown Object (File)
Thu, Apr 17, 4:06 AM
Unknown Object (File)
Wed, Apr 16, 11:03 PM
Unknown Object (File)
Wed, Apr 16, 8:52 PM
Unknown Object (File)
Wed, Apr 16, 8:09 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMM013148bf1e9d: [services] Lib - Move client base reactors
Summary

Depends on D3912

Moving client base reactors from both blob/backup to the mutual "lib" space.

Test Plan

No real changes are applied, just moving stuff around, so services should still build and that's the test plan

cd services

yarn run-blob-service
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.May 4 2022, 6:22 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 4 2022, 6:22 AM
• karol edited the summary of this revision. (Show Details)May 4 2022, 6:51 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3912: [services] Lib - Move server base reactors.
Harbormaster completed remote builds in B8771: Diff 12218.May 4 2022, 7:35 AM
• karol requested review of this revision.May 4 2022, 7:35 AM
ashoat requested changes to this revision.May 4 2022, 11:06 AM

I don't like the lib_src folder and I'd like to move away from having a different directory structure inside vs. outside Docker if possible, see feedback in D3909

This revision now requires changes to proceed.May 4 2022, 11:06 AM
• karol added a child revision: D3942: [services] Backup/Blob - Split aws tools into two tool sets.May 6 2022, 6:33 AM
• karol updated this revision to Diff 12395.May 9 2022, 2:06 AM
• karol edited the summary of this revision. (Show Details)

update

Harbormaster failed remote builds in B8891: Diff 12395!May 9 2022, 2:10 AM
• karol planned changes to this revision.May 9 2022, 2:23 AM
• karol updated this revision to Diff 12407.May 9 2022, 2:32 AM

fix ci

Harbormaster completed remote builds in B8903: Diff 12407.May 9 2022, 2:50 AM
• karol planned changes to this revision.May 9 2022, 7:15 AM

rebased

• karol updated this revision to Diff 12441.May 9 2022, 7:17 AM

rebase

Harbormaster completed remote builds in B8932: Diff 12441.May 9 2022, 7:40 AM
ashoat accepted this revision.May 9 2022, 9:32 AM
This revision is now accepted and ready to land.May 9 2022, 9:32 AM
• karol updated this revision to Diff 12466.May 10 2022, 12:55 AM

rebase

Harbormaster completed remote builds in B8956: Diff 12466.May 10 2022, 1:18 AM
Closed by commit rCOMM013148bf1e9d: [services] Lib - Move client base reactors (authored by • karol). · Explain WhyMay 10 2022, 6:39 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM013148bf1e9d: [services] Lib - Move client base reactors.

Revision Contents
Changeset List

PathSize
services/
backup/
1 line
src/
Reactors/
client/
base-reactors/
lib/
src/
client-base-reactors/
backup/
src/
Reactors/
client/
base-reactors/

Diff 12508

View Options

services/backup/CMakeLists.txt

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines device_key_upload: Some(DeviceKeyUpload {
prekey: generate_random_olm_key(), prekey: generate_random_olm_key(),
prekey_signature: "notif_prekey_sig".to_string(), prekey_signature: "notif_prekey_sig".to_string(),
}), }),
one_time_content_prekeys: Vec::new(), one_time_content_prekeys: Vec::new(),
one_time_notif_prekeys: Vec::new(), one_time_notif_prekeys: Vec::new(),
device_type: device_type.into(), device_type: device_type.into(),
}), }),
farcaster_id: None, farcaster_id: None,
initial_device_list: "".to_string(),
}; };
let mut identity_client = get_unauthenticated_client( let mut identity_client = get_unauthenticated_client(
&service_addr::IDENTITY_GRPC.to_string(), &service_addr::IDENTITY_GRPC.to_string(),
PLACEHOLDER_CODE_VERSION, PLACEHOLDER_CODE_VERSION,
DEVICE_TYPE.to_string(), DEVICE_TYPE.to_string(),
) )
.await .await
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines device_key_upload: Some(DeviceKeyUpload {
prekey: generate_random_olm_key(), prekey: generate_random_olm_key(),
prekey_signature: "notif_prekey_sig".to_string(), prekey_signature: "notif_prekey_sig".to_string(),
}), }),
one_time_content_prekeys: Vec::new(), one_time_content_prekeys: Vec::new(),
one_time_notif_prekeys: Vec::new(), one_time_notif_prekeys: Vec::new(),
device_type: device_type.into(), device_type: device_type.into(),
}), }),
farcaster_id: None, farcaster_id: None,
initial_device_list: "".to_string(),
}; };
let mut identity_client = get_unauthenticated_client( let mut identity_client = get_unauthenticated_client(
&service_addr::IDENTITY_GRPC.to_string(), &service_addr::IDENTITY_GRPC.to_string(),
PLACEHOLDER_CODE_VERSION, PLACEHOLDER_CODE_VERSION,
DEVICE_TYPE.to_string(), DEVICE_TYPE.to_string(),
) )
.await .await
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientReadReactorBase.h

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines device_key_upload: Some(DeviceKeyUpload {
prekey: generate_random_olm_key(), prekey: generate_random_olm_key(),
prekey_signature: "notif_prekey_sig".to_string(), prekey_signature: "notif_prekey_sig".to_string(),
}), }),
one_time_content_prekeys: Vec::new(), one_time_content_prekeys: Vec::new(),
one_time_notif_prekeys: Vec::new(), one_time_notif_prekeys: Vec::new(),
device_type: device_type.into(), device_type: device_type.into(),
}), }),
farcaster_id: None, farcaster_id: None,
initial_device_list: "".to_string(),
}; };
let mut identity_client = get_unauthenticated_client( let mut identity_client = get_unauthenticated_client(
&service_addr::IDENTITY_GRPC.to_string(), &service_addr::IDENTITY_GRPC.to_string(),
PLACEHOLDER_CODE_VERSION, PLACEHOLDER_CODE_VERSION,
DEVICE_TYPE.to_string(), DEVICE_TYPE.to_string(),
) )
.await .await
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines device_key_upload: Some(DeviceKeyUpload {
prekey: generate_random_olm_key(), prekey: generate_random_olm_key(),
prekey_signature: "notif_prekey_sig".to_string(), prekey_signature: "notif_prekey_sig".to_string(),
}), }),
one_time_content_prekeys: Vec::new(), one_time_content_prekeys: Vec::new(),
one_time_notif_prekeys: Vec::new(), one_time_notif_prekeys: Vec::new(),
device_type: device_type.into(), device_type: device_type.into(),
}), }),
farcaster_id: None, farcaster_id: None,
initial_device_list: "".to_string(),
}; };
let mut identity_client = get_unauthenticated_client( let mut identity_client = get_unauthenticated_client(
&service_addr::IDENTITY_GRPC.to_string(), &service_addr::IDENTITY_GRPC.to_string(),
PLACEHOLDER_CODE_VERSION, PLACEHOLDER_CODE_VERSION,
DEVICE_TYPE.to_string(), DEVICE_TYPE.to_string(),
) )
.await .await
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines
View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...