Details

Reviewers

tomek
ashoat

Commits

rCOMM013148bf1e9d: [services] Lib - Move client base reactors

Summary

Depends on D3912

Moving client base reactors from both blob/backup to the mutual "lib" space.

Test Plan

No real changes are applied, just moving stuff around, so services should still build and that's the test plan

cd services

yarn run-blob-service
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.May 4 2022, 6:22 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 4 2022, 6:22 AM

• karol edited the summary of this revision. (Show Details)May 4 2022, 6:51 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3912: [services] Lib - Move server base reactors.

Harbormaster completed remote builds in B8771: Diff 12218.May 4 2022, 7:35 AM

• karol requested review of this revision.May 4 2022, 7:35 AM

I don't like the lib_src folder and I'd like to move away from having a different directory structure inside vs. outside Docker if possible, see feedback in D3909

This revision now requires changes to proceed.May 4 2022, 11:06 AM

• karol added a child revision: D3942: [services] Backup/Blob - Split aws tools into two tool sets.May 6 2022, 6:33 AM

update

Harbormaster failed remote builds in B8891: Diff 12395!May 9 2022, 2:10 AM

• karol planned changes to this revision.May 9 2022, 2:23 AM

fix ci

Harbormaster completed remote builds in B8903: Diff 12407.May 9 2022, 2:50 AM

rebased

rebase

Harbormaster completed remote builds in B8932: Diff 12441.May 9 2022, 7:40 AM

ashoat accepted this revision.May 9 2022, 9:32 AM

This revision is now accepted and ready to land.May 9 2022, 9:32 AM

rebase

Harbormaster completed remote builds in B8956: Diff 12466.May 10 2022, 1:18 AM

Closed by commit rCOMM013148bf1e9d: [services] Lib - Move client base reactors (authored by • karol). · Explain WhyMay 10 2022, 6:39 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM013148bf1e9d: [services] Lib - Move client base reactors.

[services] Lib - Move client base reactors
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 12508

services/backup/CMakeLists.txt

services/backup/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

services/backup/src/Reactors/client/base-reactors/ClientReadReactorBase.h

services/backup/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

services/lib/src/client-base-reactors/ClientReadReactorBase.h

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

[services] Lib - Move client base reactorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12508

services/backup/CMakeLists.txt

services/backup/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

services/backup/src/Reactors/client/base-reactors/ClientReadReactorBase.h

services/backup/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

services/lib/src/client-base-reactors/ClientReadReactorBase.h

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

[services] Lib - Move client base reactors
ClosedPublic
Actions

Revision Contents
Changeset List