As discussed in https://phabricator.ashoat.com/D4028#115409, we need to receive the device id from the client in order to properly generate the backup id.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/grpc/protos/backup.proto | ||
|---|---|---|
| 31–37 ↗ | (On Diff #12992) | At some point we should stop modifying the existing fields and only add a new ones. |
| services/backup/src/Reactors/server/CreateNewBackupReactor.cpp | ||
| 23–38 ↗ | (On Diff #12992) | I think it was discussed a couple of times, but having to send these one by one isn't too effective |
| services/backup/src/Reactors/server/CreateNewBackupReactor.cpp | ||
|---|---|---|
| 23–38 ↗ | (On Diff #12992) | I believe this is the task for this https://linear.app/comm/issue/ENG-1052/reconsider-using-oneof-in-services. I think we can do this separately. |
| services/backup/src/Reactors/server/CreateNewBackupReactor.cpp | ||
|---|---|---|
| 23–38 ↗ | (On Diff #12992) | It would be good to prioritize this task, but I agree it doesn't make sense to change in this diff |