Differential D4099

[services] Backup - receive device id when creating new backup
ClosedPublic
Actions

Authored by • karol on May 23 2022, 2:46 AM.

Tags

None

Referenced Files

	F3765266: D4099.diff
	Sat, Jan 11, 3:10 PM

	Unknown Object (File)
	Fri, Dec 27, 11:04 AM

	Unknown Object (File)
	Wed, Dec 25, 5:41 PM

	Unknown Object (File)
	Wed, Dec 25, 6:26 AM

	Unknown Object (File)
	Sun, Dec 15, 8:48 AM

	Unknown Object (File)
	Sun, Dec 15, 8:48 AM

	Unknown Object (File)
	Sun, Dec 15, 8:48 AM

	Unknown Object (File)
	Sun, Dec 15, 8:44 AM

Subscribers

Details

Reviewers

tomek
ashoat

Commits

rCOMM0549c04100ba: [services] Backup - receive device id when creating new backup

Summary

As discussed in https://phabricator.ashoat.com/D4028#115409, we need to receive the device id from the client in order to properly generate the backup id.

Test Plan

You can use my repo grpc-playground, this commit adds the device id.

Diff Detail

Repository

Branch

pass-device-id

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 23 2022, 2:46 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 23 2022, 2:46 AM

• karol added a child revision: D4028: [services] Backup - generate backup id.May 23 2022, 2:48 AM

• karol edited the summary of this revision. (Show Details)May 23 2022, 2:51 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, ashoat.

Harbormaster completed remote builds in B9375: Diff 12992.May 23 2022, 2:51 AM

• karol requested review of this revision.May 23 2022, 2:51 AM

• karol mentioned this in D4028: [services] Backup - generate backup id.May 23 2022, 2:51 AM

tomek accepted this revision.May 23 2022, 4:09 AM

tomek added inline comments.

native/cpp/CommonCpp/grpc/protos/backup.proto
31–37	At some point we should stop modifying the existing fields and only add a new ones.
services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
23–38	I think it was discussed a couple of times, but having to send these one by one isn't too effective

This revision is now accepted and ready to land.May 23 2022, 4:09 AM

• karol added inline comments.May 23 2022, 5:07 AM

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
23–38	I believe this is the task for this https://linear.app/comm/issue/ENG-1052/reconsider-using-oneof-in-services. I think we can do this separately.

ashoat accepted this revision.May 23 2022, 10:52 AM

ashoat added inline comments.

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
23–38	It would be good to prioritize this task, but I agree it doesn't make sense to change in this diff

Closed by commit rCOMM0549c04100ba: [services] Backup - receive device id when creating new backup (authored by • karol). · Explain WhyMay 25 2022, 3:24 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM0549c04100ba: [services] Backup - receive device id when creating new backup.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

protos/

7 lines

services/

backup/

src/

Reactors/

server/

CreateNewBackupReactor.h

8 lines

CreateNewBackupReactor.cpp

8 lines

Diff 12992

native/cpp/CommonCpp/grpc/protos/backup.proto

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.h

Loading...

services/backup/src/Reactors/server/CreateNewBackupReactor.cpp

Loading...