Details

Reviewers

tomek
ashoat

Commits

rCOMMe6ccec347979: [services] Lib - Move dynamo DB tools

Summary

Depends on D3942

Moving the aws tools for dynamo DB to the "lib" space, so they can be used by all services that need the database access on AWS.

Test Plan

cd services
yarn run-local-cloud
yarn test-backup-service-dev-mode
yarn test-blob-service-dev-mode

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.May 6 2022, 1:29 PM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 6 2022, 1:29 PM

Harbormaster completed remote builds in B8854: Diff 12350.May 6 2022, 1:34 PM

• karol requested review of this revision.May 6 2022, 1:34 PM

• karol edited the summary of this revision. (Show Details)May 6 2022, 1:34 PM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3942: [services] Backup/Blob - Split aws tools into two tool sets.

• karol added a child revision: D3950: [services] Lib - Introduce Global Constants.May 6 2022, 2:49 PM

• karol planned changes to this revision.May 9 2022, 9:07 AM

update

Harbormaster failed remote builds in B8893: Diff 12397!May 9 2022, 9:12 AM

• karol planned changes to this revision.May 9 2022, 9:23 AM

fix ci

Harbormaster completed remote builds in B8905: Diff 12409.May 9 2022, 9:53 AM

ashoat requested changes to this revision.May 9 2022, 4:20 PM

ashoat added inline comments.

services/blob/CMakeLists.txt
29 ↗	(On Diff #12409)	Should `lib_src` be removed here? Assuming based on your update comments in D3909 where you removed it

This revision now requires changes to proceed.May 9 2022, 4:20 PM

• karol added inline comments.May 10 2022, 7:48 AM

services/blob/CMakeLists.txt
29 ↗	(On Diff #12409)	yes, I missed this, thx

remove cmakelists entries with lib_src

Harbormaster completed remote builds in B8951: Diff 12461.May 10 2022, 7:56 AM

ashoat accepted this revision.May 10 2022, 12:46 PM

This revision is now accepted and ready to land.May 10 2022, 12:46 PM

Closed by commit rCOMMe6ccec347979: [services] Lib - Move dynamo DB tools. · Explain WhyMay 10 2022, 1:39 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMe6ccec347979: [services] Lib - Move dynamo DB tools.

[services] Lib - Move dynamo DB tools
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 12510

services/backup/src/DynamoDBTools.h

services/backup/src/DynamoDBTools.cpp

services/blob/CMakeLists.txt

services/blob/src/DynamoDBTools.h

services/blob/src/DynamoDBTools.cpp

services/lib/src/DynamoDBTools.h

services/lib/src/DynamoDBTools.cpp

[services] Lib - Move dynamo DB toolsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12510

services/backup/src/DynamoDBTools.h

services/backup/src/DynamoDBTools.cpp

services/blob/CMakeLists.txt

services/blob/src/DynamoDBTools.h

services/blob/src/DynamoDBTools.cpp

services/lib/src/DynamoDBTools.h

services/lib/src/DynamoDBTools.cpp

[services] Lib - Move dynamo DB tools
ClosedPublic
Actions

Revision Contents
Changeset List