Page MenuHomePhabricator

[services] Backup - New backup - make created consistent
AbandonedPublic

Authored by karol on May 13 2022, 2:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 7:32 AM
Unknown Object (File)
Sat, Sep 7, 3:05 AM
Unknown Object (File)
Tue, Sep 3, 5:25 AM
Unknown Object (File)
Tue, Sep 3, 5:25 AM
Unknown Object (File)
Tue, Sep 3, 5:20 AM
Unknown Object (File)
Aug 28 2024, 2:43 AM
Unknown Object (File)
Aug 28 2024, 2:35 AM
Unknown Object (File)
Aug 26 2024, 5:03 AM

Details

Reviewers
tomek
Summary

Depends on D4028

Since we'll need the created field in multiple places in the database (backup item, backup id in holder in the blob item) it's good that it's the same value

Test Plan

Run the blob service
Run the backup service
Use grpc-playground to make a call creating a new backup

Check in the database that the new backup item and the holder for the reverse index item (in the blob) have the same part derived from the created field - you can also log this out in the code.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2022, 2:27 AM
Harbormaster failed remote builds in B9080: Diff 12626!
karol edited the test plan for this revision. (Show Details)
karol added a reviewer: tomek.

services build passed

tomek requested changes to this revision.May 17 2022, 3:22 AM
tomek added inline comments.
services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
19

Aren't we going to update the value every time this method is called? Does that make sense?

This revision now requires changes to proceed.May 17 2022, 3:22 AM

I think we can abandon this since we're not using the timestamp in D4028 anymore