Paths

Table of Contentst

-
native/chat/
-
chat/
1/1
chat-item-height-measurer.react.js
1/1
chat-list.react.js
1/1
chat-message-constants.js
1/1
message-list.react.js

[native] [reactor] [ENG-530] fix hot reload export issue in chat message
ClosedPublic
Actions

Authored by • benschac on May 9 2022, 12:32 PM.

Details

Reviewers

atul
• jacek
tomek
• derek

Commits

rCOMMcee86c5d6cb7: [native] [reactor] [ENG-530] fix hot reload export issue in chat message

Summary

Fix hot reload issues coming from react components exported with additional variables https://twitter.com/benschac/status/1521867664267821063?s=20&t=hKhwNWhJqqDsPU5nB2Qexw

Test Plan

no functional change. when editing chat-list.react.js hot-reload will not push the engineer back to the inbox.

Diff Detail

Repository

rCOMM Comm

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 9 2022, 12:32 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 9 2022, 12:32 PM

• benschac edited the test plan for this revision. (Show Details)May 9 2022, 12:33 PM

• benschac added a parent revision: D3971: [refactor] [native] [ENG-530] Remove positioning prop from InlineSidebar component.

Harbormaster completed remote builds in B8938: Diff 12448.May 9 2022, 12:37 PM

• benschac requested review of this revision.May 9 2022, 12:37 PM

Makes sense to pull out the helper function.

Is there a reason we call this file chat-message-constants? I might be missing something but it doesn't look like we're keeping constant values in it?

Maybe something like chat-message-utils?

This revision is now accepted and ready to land.May 10 2022, 6:52 AM

In D3972#111889, @atul wrote:

Makes sense to pull out the helper function.

Is there a reason we call this file chat-message-constants? I might be missing something but it doesn't look like we're keeping constant values in it?

Maybe something like chat-message-utils?

I just named it that because that's what I named the other files that had removed additional exports from (that broke hot reload). I was thinking of just moving all of the constants into one utils file now that there are a couple of different constants files.

• benschac mentioned this in D3996: [native] [refactor] [ENG-530] organize constants and utils in chat directory.May 10 2022, 8:34 AM

Addressed @atul's comment here: https://phabricator.ashoat.com/D3996 moved chatMessageItemKey into the util chat/util file.

• benschac added a child revision: D3996: [native] [refactor] [ENG-530] organize constants and utils in chat directory.May 10 2022, 8:36 AM

Closed by commit rCOMMcee86c5d6cb7: [native] [reactor] [ENG-530] fix hot reload export issue in chat message (authored by • benschac). · Explain WhyMay 10 2022, 9:41 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMcee86c5d6cb7: [native] [reactor] [ENG-530] fix hot reload export issue in chat message.

• benschac mentioned this in rCOMM3f375584326c: [native] [refactor] [ENG-530] organize constants and utils in chat directory.May 11 2022, 5:42 AM

ashoat mentioned this in D5972: [native] Add subchannnels modal.Dec 22 2022, 8:00 AM

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-item-height-measurer.react.js

2 lines

chat-list.react.js

15 lines

chat-message-constants.js

15 lines

message-list.react.js

2 lines

Diff 12448

View Options

native/chat/chat-item-height-measurer.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

native/chat/chat-list.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

native/chat/chat-message-constants.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

native/chat/message-list.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

[native] [reactor] [ENG-530] fix hot reload export issue in chat messageClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12448

native/chat/chat-item-height-measurer.react.js

native/chat/chat-list.react.js

native/chat/chat-message-constants.js

native/chat/message-list.react.js

[native] [reactor] [ENG-530] fix hot reload export issue in chat message
ClosedPublic
Actions

Revision Contents
Changeset List