[native] [refactor] [ENG-530] organize constants and utils in chat directory
ClosedPublic
Actions

Authored by • benschac on May 10 2022, 8:34 AM.

Details

Reviewers

atul
tomek
• derek
• jacek

Commits

rCOMM3f375584326c: [native] [refactor] [ENG-530] organize constants and utils in chat directory

Summary

after @atul 's comment here: https://phabricator.ashoat.com/D3972, I organized the constants in the native directory and moved a function to the chat util files.

Test Plan

no new functionality. Everything works the same, no flow or eslint errors.

Diff Detail

Repository

rCOMM Comm

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 10 2022, 8:34 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 8:34 AM

• benschac mentioned this in D3972: [native] [reactor] [ENG-530] fix hot reload export issue in chat message.May 10 2022, 8:35 AM

• benschac added a parent revision: D3972: [native] [reactor] [ENG-530] fix hot reload export issue in chat message.

Harbormaster completed remote builds in B8990: Diff 12522.May 10 2022, 8:41 AM

• benschac requested review of this revision.May 10 2022, 8:41 AM

• benschac added a child revision: D3997: [native] [refactor] [ENG-530] refactor container margin bottom if statement.May 10 2022, 10:36 AM

tomek accepted this revision.May 11 2022, 5:30 AM

This revision is now accepted and ready to land.May 11 2022, 5:30 AM

Closed by commit rCOMM3f375584326c: [native] [refactor] [ENG-530] organize constants and utils in chat directory (authored by • benschac). · Explain WhyMay 11 2022, 5:42 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM3f375584326c: [native] [refactor] [ENG-530] organize constants and utils in chat directory.

Revision Contents
Changeset List

Path

Size

native/

chat/

	chat-constants.js
	inline-sidebar-constants.js

2 lines

chat-item-height-measurer.react.js

2 lines

chat-list.react.js

3 lines

chat-message-constants.js

composed-message-constants.js

composed-message.react.js

10 lines

inline-sidebar-constants.js

inline-sidebar.react.js

2 lines

message-header.react.js

2 lines

multimedia-message-utils.js

6 lines

utils.js

19 lines

Diff 12522

View Options

native/chat/chat-constants.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

native/chat/chat-item-height-measurer.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

native/chat/chat-list.react.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };

View Options

native/chat/chat-message-constants.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };