Paths

Table of Contentst

Differential D3997

[native] [refactor] [ENG-530] refactor container margin bottom if statement
ClosedPublic
Actions

Authored by • benschac on May 10 2022, 10:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 11:07 AM

	Unknown Object (File)
	Fri, Nov 8, 12:47 PM

	Unknown Object (File)
	Mon, Oct 28, 7:32 AM

	Unknown Object (File)
	Oct 19 2024, 10:46 PM

	Unknown Object (File)
	Oct 19 2024, 1:19 PM

	Unknown Object (File)
	Oct 19 2024, 1:19 PM

	Unknown Object (File)
	Oct 19 2024, 1:19 PM

	Unknown Object (File)
	Oct 19 2024, 1:19 PM

Subscribers

Details

Reviewers

atul
tomek
• jacek
• derek

Commits

rCOMM206d81a9a618: [native] [refactor] [ENG-530] refactor container margin bottom if statement

Summary

use if else syntax the that's used project wide.

before:

image.png (320×566 px, 28 KB)

after:

image.png (320×470 px, 28 KB)

Test Plan

Cluster margin should work as expected in chat view.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 10 2022, 10:36 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 10 2022, 10:36 AM

• benschac added a parent revision: D3996: [native] [refactor] [ENG-530] organize constants and utils in chat directory.May 10 2022, 10:36 AM

• benschac edited the summary of this revision. (Show Details)

• benschac edited the summary of this revision. (Show Details)

• benschac added inline comments.May 10 2022, 10:39 AM

native/chat/composed-message.react.js
78 ↗	(On Diff #12525)	Additionally, I need to add another condition in here and using an if else is easier to read here.

Harbormaster completed remote builds in B8991: Diff 12525.May 10 2022, 10:41 AM

• benschac requested review of this revision.May 10 2022, 10:41 AM

[native] [fix] [ENG-1123] update chat bubble design

Harbormaster completed remote builds in B8992: Diff 12526.May 10 2022, 11:46 AM

• benschac added a child revision: D3998: [native] [fix] [ENG-1123] update message chat bubble design to match design (more padding and line height).May 10 2022, 11:56 AM

This is not only a refactor, but it also changes the logic. In the previous version, when item.endsCluster then marginBottom: 5 + clusterEndHeight, but now marginBottom: clusterEndHeight. Is that intentional?

This revision now requires changes to proceed.May 11 2022, 5:46 AM

fix logic

In D3997#112145, @palys-swm wrote:

This is not only a refactor, but it also changes the logic. In the previous version, when item.endsCluster then marginBottom: 5 + clusterEndHeight, but now marginBottom: clusterEndHeight. Is that intentional?

You're right, thanks for catching this.

Harbormaster failed remote builds in B8997: Diff 12535!May 11 2022, 6:06 AM

tomek accepted this revision.May 11 2022, 6:08 AM

This revision is now accepted and ready to land.May 11 2022, 6:08 AM

Harbormaster completed remote builds in B8997: Diff 12535.May 11 2022, 9:25 AM

Closed by commit rCOMM206d81a9a618: [native] [refactor] [ENG-530] refactor container margin bottom if statement (authored by • benschac). · Explain WhyMay 11 2022, 11:42 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM206d81a9a618: [native] [refactor] [ENG-530] refactor container margin bottom if statement.

Revision Contents
Changeset List

Path

Size

native/

chat/

composed-message.react.js

8 lines

Diff 12535

native/chat/composed-message.react.js

Loading...