Necessary for backup service
Depends on D4491
Paths
| Differential D4492 Authored by • jon on Jul 8 2022, 10:51 PM.
Tags None Referenced Files
Details Summary Necessary for backup service Depends on D4491 Test Plan Run test plan from https://phab.comm.dev/D4494
Diff Detail
Event TimelineHerald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJul 8 2022, 10:51 PM2022-07-08 22:51:16 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 8 2022, 10:53 PM2022-07-08 22:53:39 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 9:05 PM2022-07-25 21:05:24 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 9:52 AM2022-07-29 09:52:04 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2022, 3:06 PM2022-07-29 15:06:24 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Aug 1 2022, 1:17 PM2022-08-01 13:17:14 (UTC-7) Comment Actions Copied from D4491: At a high level this looks good but A. It looks like some of the CI workflows are failing, could you provide some context if that's to be expected? This revision now requires changes to proceed.Aug 3 2022, 5:11 PM2022-08-03 17:11:00 (UTC-7) • jon edited the test plan for this revision. (Show Details)Aug 3 2022, 7:35 PM2022-08-03 19:35:48 (UTC-7) Comment Actions Yes, it's meant to fail right now, I could have rebased to be before the tunnelbroker changes, but it's hard to order this work in some way. I chose to do batch them logically "as needed by later changes". I updated the test plan. I eventually fix the gates again, but I had to change both backup and blob to do so. I tried to make the individual diffs as small as possible. Harbormaster completed remote builds in B11099: Diff 15290.Aug 3 2022, 9:41 PM2022-08-03 21:41:48 (UTC-7) Comment Actions Looks good, appreciate the rebasing and reordering to appease the CI.
This revision is now accepted and ready to land.Aug 4 2022, 11:51 AM2022-08-04 11:51:03 (UTC-7) Harbormaster completed remote builds in B11164: Diff 15368.Aug 5 2022, 11:42 AM2022-08-05 11:42:17 (UTC-7) • jon added inline comments.
Closed by commit rCOMMfd098d391542: [Services] Export server-base-reactors as CMake Project (authored by • jon). · Explain WhyAug 8 2022, 11:34 AM2022-08-08 11:34:46 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 15121 services/lib/src/server-base-reactors/CMakeLists.txt
|