[keyserver] Introduce getDBType function to distinguish MySQL and MariaDB
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 3:40 PM.

Details

Reviewers

atul
tomek
• jon

Commits

rCOMMe2cb36c1a0d9: [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB

Summary

Depends on D4516

Test Plan

Tested in combination with next diffs

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/mariadb

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jul 13 2022, 3:40 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 3:40 PM

Harbormaster completed remote builds in B10490: Diff 14437.Jul 13 2022, 3:53 PM

ashoat requested review of this revision.Jul 13 2022, 3:53 PM

ashoat added a child revision: D4519: [keyserver] Make rawMessageInfoFromRows return a Promise.Jul 13 2022, 4:08 PM

Not super qualified to review js, but doesn't look wrong in any regards

atul accepted this revision.Jul 15 2022, 7:18 PM

This revision is now accepted and ready to land.Jul 15 2022, 7:18 PM

Closed by commit rCOMMe2cb36c1a0d9: [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB. · Explain WhyJul 18 2022, 3:13 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe2cb36c1a0d9: [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

db-config.js

10 lines

Diff 14437

View Options

keyserver/src/database/db-config.js

[keyserver] Introduce getDBType function to distinguish MySQL and MariaDBClosedPublicActions