Page MenuHomePhabricator
Differential D4735

[Services] Remove build_services compatibility logic
ClosedPublic
Actions

Authored by • jon on Aug 3 2022, 11:29 PM.
Tags
None
Referenced Files
F2833880: D4735.diff
Sat, Sep 28, 9:21 AM
F2829666: D4735.id15453.diff
Fri, Sep 27, 4:58 PM
F2829665: D4735.id15442.diff
Fri, Sep 27, 4:58 PM
F2829664: D4735.id15393.diff
Fri, Sep 27, 4:58 PM
F2829663: D4735.id15298.diff
Fri, Sep 27, 4:58 PM
F2829640: D4735.id.diff
Fri, Sep 27, 4:58 PM
F2829565: D4735.diff
Fri, Sep 27, 4:53 PM
Unknown Object (File)
Wed, Sep 25, 2:36 AM
View All Files
Subscribers
• adrian
ashoat
tomek

Details

Reviewers
• abosh
atul
• max
• karol
Commits
rCOMM8d3670c56c1a: [Services] Remove build_services compatibility logic
Summary

This largely undoes the compatibility logic in D4734 to make
gates pass.

Since blob, backup, and tunnelbroker have been updated, there's no reason to
use the legacy "special paths" docker-specific workflow

Test Plan

Blob, Backup, and Tunnelbroker gates pass

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 3 2022, 11:29 PM
Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptAug 3 2022, 11:29 PM
Harbormaster completed remote builds in B11107: Diff 15298.Aug 3 2022, 11:42 PM
• jon requested review of this revision.Aug 3 2022, 11:42 PM
• jon added a parent revision: D4494: [Services] Update backup CMake.Aug 3 2022, 11:56 PM
• jon mentioned this in D4734: [Services] Allow for docker paths and system packages.
atul accepted this revision.Aug 4 2022, 11:52 AM
This revision is now accepted and ready to land.Aug 4 2022, 11:52 AM
• jon added a child revision: D4757: [Services] Use shared services CMake project from tunnelbroker.Aug 5 2022, 12:14 PM
• jon updated this revision to Diff 15393.Aug 5 2022, 5:16 PM

Rebase with MacOS Fixes

Harbormaster completed remote builds in B11186: Diff 15393.Aug 5 2022, 5:31 PM
• abosh accepted this revision.Aug 8 2022, 10:02 AM
• jon mentioned this in rCOMM1ce887c5239d: [Services] Allow for docker paths and system packages.Aug 8 2022, 11:34 AM
• jon updated this revision to Diff 15442.Aug 8 2022, 11:43 AM

Rebase

Harbormaster completed remote builds in B11224: Diff 15442.Aug 8 2022, 11:57 AM
Closed by commit rCOMM8d3670c56c1a: [Services] Remove build_services compatibility logic (authored by • jon). · Explain WhyAug 8 2022, 1:45 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM8d3670c56c1a: [Services] Remove build_services compatibility logic.

Revision Contents
Changeset List

PathSize
services/
lib/
docker/
23 lines

Diff 15393

View Options

services/lib/docker/build_service.sh

Loading...