[DRAFT] [services] Backup - Connect to Blob - add error messages for async errors
AbandonedPublic
Actions

Authored by • karol on Aug 24 2022, 5:56 AM.

Details

Reviewers

varun
tomek
• jon

Summary

Depends on D4943

I didn't know how to properly handle errors in the async blocks so I just added a collection to gather them.

@varun any better ideas?

Test Plan

Test plan in D4946

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 24 2022, 5:56 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 24 2022, 5:56 AM

• karol retitled this revision from [services] Backup - Connect to Blob - add error messages for async errors to [DRAFT] [services] Backup - Connect to Blob - add error messages for async errors.Aug 24 2022, 6:03 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: varun, tomek.

• karol added a parent revision: D4943: [DRAFT] [services] Blob - check for holder/hash presence in terminate callback.

• karol added a child revision: D4945: [DRAFT] [services] Backup - Connect to Blob - Use Result.

• karol added a subscriber: varun.

Harbormaster completed remote builds in B11580: Diff 15921.Aug 24 2022, 6:07 AM

• karol requested review of this revision.Aug 24 2022, 6:07 AM

Not sure how these functions will be used, but I guess if an error occurs, we can just stop the execution of a method and set a value in future.

services/backup/blob_client/src/put_client.rs
56–63	We don't need to use an explicit return as a last statement We should avoid mutable variables

This revision now requires changes to proceed.Aug 29 2022, 4:38 AM

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 4:38 AM

• karol added inline comments.Aug 30 2022, 2:20 AM

services/backup/blob_client/src/put_client.rs
56–63	ok

address comment

Harbormaster failed remote builds in B11709: Diff 16098!Aug 30 2022, 2:28 AM

• karol planned changes to this revision.Aug 30 2022, 2:45 AM

Abandoning this stack in favor of the new one that starts @ D5002.

All the comments have been either addressed inline or in the new stack.

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

put_client.rs

21 lines

Diff 15921

View Options

services/backup/blob_client/src/put_client.rs

[DRAFT] [services] Backup - Connect to Blob - add error messages for async errorsAbandonedPublicActions