[native] [27/34] ReactNav6: Move some stack exports to elements
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 1:19 PM.

Details

Reviewers

atul
tomek
bartek

Commits

rCOMMcc070252ae43: [native] [27/34] ReactNav6: Move some stack exports to elements

Summary

Context on change here.

Depends on D5419

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 20 2022, 1:19 PM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 1:19 PM

ashoat added a child revision: D5421: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar.Oct 20 2022, 1:19 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 1:40 PM

Harbormaster failed remote builds in B12907: Diff 17698!

ashoat requested review of this revision.Oct 20 2022, 2:24 PM

ashoat added inline comments.

native/navigation/header-back-button.react.js
3	This causes build failures until D5427, which actually introduces the package. Sorry!!

ashoat mentioned this in D5421: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar.Oct 20 2022, 2:25 PM

ashoat mentioned this in D5422: [native] [29/34] ReactNav6: Merge tabBarOptions into options.

ashoat mentioned this in D5423: [native] [30/34] ReactNav6: Remove tabBarVisible option.

ashoat mentioned this in D5424: [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options.

ashoat mentioned this in D5425: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator.

ashoat mentioned this in D5426: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning.

atul accepted this revision.Oct 20 2022, 7:53 PM

This revision is now accepted and ready to land.Oct 20 2022, 7:54 PM

This revision was landed with ongoing or failed builds.Oct 20 2022, 8:47 PM

Closed by commit rCOMMcc070252ae43: [native] [27/34] ReactNav6: Move some stack exports to elements. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcc070252ae43: [native] [27/34] ReactNav6: Move some stack exports to elements.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-list-header-title.react.js

2 lines

flow-typed/

npm/

@react-navigation/

	elements_v1.x.x.js
	stack_v5.x.x.js

93 lines

stack_v5.x.x.js

34 lines

navigation/

header-back-button.react.js

2 lines

Diff 17698

View Options

native/chat/message-list-header-title.react.js

View Options

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

View Options

native/navigation/header-back-button.react.js

[native] [27/34] ReactNav6: Move some stack exports to elementsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17698

native/chat/message-list-header-title.react.js

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

native/navigation/header-back-button.react.js

[native] [27/34] ReactNav6: Move some stack exports to elements
ClosedPublic
Actions

Revision Contents
Changeset List