Page MenuHomePhabricator
Differential D5420

[native] [27/34] ReactNav6: Move some stack exports to elements
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Sun, Oct 20, 6:15 PM
Unknown Object (File)
Oct 6 2024, 1:45 AM
Unknown Object (File)
Oct 6 2024, 1:45 AM
Unknown Object (File)
Oct 6 2024, 1:44 AM
Unknown Object (File)
Oct 6 2024, 1:39 AM
Unknown Object (File)
Sep 9 2024, 7:47 PM
Unknown Object (File)
Sep 9 2024, 7:46 PM
View All Files
Subscribers
• abosh

Details

Reviewers
atul
tomek
bartek
Commits
rCOMMcc070252ae43: [native] [27/34] ReactNav6: Move some stack exports to elements
Summary

Context on change here.

Depends on D5419

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:19 AM
Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:19 AM
ashoat added a child revision: D5421: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar.Oct 20 2022, 6:19 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2022, 6:40 AM
Harbormaster failed remote builds in B12907: Diff 17698!
ashoat requested review of this revision.Oct 20 2022, 7:24 AM
ashoat added inline comments.
native/navigation/header-back-button.react.js
3 ↗(On Diff #17698)

This causes build failures until D5427, which actually introduces the package. Sorry!!

ashoat mentioned this in D5421: [native] [28/34] ReactNav6: Specify headerShown: false for tab bar.Oct 20 2022, 7:25 AM
ashoat mentioned this in D5422: [native] [29/34] ReactNav6: Merge tabBarOptions into options.
ashoat mentioned this in D5423: [native] [30/34] ReactNav6: Remove tabBarVisible option.
ashoat mentioned this in D5424: [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options.
ashoat mentioned this in D5425: [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator.
ashoat mentioned this in D5426: [native] [33/34] ReactNav6: Update HeaderTitle to use flex positioning.
atul accepted this revision.Oct 20 2022, 12:53 PM
This revision is now accepted and ready to land.Oct 20 2022, 12:54 PM
This revision was landed with ongoing or failed builds.Oct 20 2022, 1:47 PM
Closed by commit rCOMMcc070252ae43: [native] [27/34] ReactNav6: Move some stack exports to elements (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMcc070252ae43: [native] [27/34] ReactNav6: Move some stack exports to elements.

Revision Contents
Changeset List

PathSize
native/
chat/
2 lines
flow-typed/
npm/
@react-navigation/
elements_v1.x.x.js
stack_v5.x.x.js
93 lines
34 lines
navigation/
2 lines

Diff 17783

View Options

native/chat/message-list-header-title.react.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/elements_v1.x.x.js

Loading...
View Options

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...
View Options

native/navigation/header-back-button.react.js

Loading...