Page MenuHomePhabricator
Differential D5765

[native] Normalize Android MarkdownLink behavior to match iOS
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:52 AM
Unknown Object (File)
Feb 11 2025, 4:11 AM
Unknown Object (File)
Jan 29 2025, 12:41 AM
Unknown Object (File)
Jan 29 2025, 12:41 AM
Unknown Object (File)
Jan 29 2025, 12:41 AM
View All Files
Subscribers
tomek

Details

Reviewers
rohan
atul
ginsu
michal
Commits
rCOMM7988ebdc2edd: [native] Normalize Android MarkdownLink behavior to match iOS
Test Plan

I tested this on iOS and Android while pressing all over a message, before and after opening the modal. See attached video in previous diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
chat/
12 lines
markdown/
1 line
38 lines

Diff 19025

View Options

native/chat/text-message.react.js

Show All 10 Lines
import * as React from 'react'; import * as React from 'react';
import { NavLink } from 'react-router-dom'; import { NavLink } from 'react-router-dom';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import css from './header.css'; import css from './header.css';
import typography from './typography.css'; import typography from './typography.css';
// This value comes from the breakpoint value in header.css. Please make sure
// that this value is in sync with header.css if ever changed
export const HEADER_BREAKPOINT = 848; // px
type Props = { type Props = {
+showMobileNav: boolean, +showMobileNav: boolean,
+setShowMobileNav: SetState<boolean>, +setShowMobileNav: SetState<boolean>,
}; };
function Header(props: Props): React.Node { function Header(props: Props): React.Node {
const { showMobileNav, setShowMobileNav } = props; const { showMobileNav, setShowMobileNav } = props;
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines
View Options

native/markdown/markdown-link-context.js

Show All 10 Lines
import * as React from 'react'; import * as React from 'react';
import { NavLink } from 'react-router-dom'; import { NavLink } from 'react-router-dom';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import css from './header.css'; import css from './header.css';
import typography from './typography.css'; import typography from './typography.css';
// This value comes from the breakpoint value in header.css. Please make sure
// that this value is in sync with header.css if ever changed
export const HEADER_BREAKPOINT = 848; // px
type Props = { type Props = {
+showMobileNav: boolean, +showMobileNav: boolean,
+setShowMobileNav: SetState<boolean>, +setShowMobileNav: SetState<boolean>,
}; };
function Header(props: Props): React.Node { function Header(props: Props): React.Node {
const { showMobileNav, setShowMobileNav } = props; const { showMobileNav, setShowMobileNav } = props;
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines
View Options

native/markdown/markdown-link.react.js

Show All 10 Lines
import * as React from 'react'; import * as React from 'react';
import { NavLink } from 'react-router-dom'; import { NavLink } from 'react-router-dom';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import css from './header.css'; import css from './header.css';
import typography from './typography.css'; import typography from './typography.css';
// This value comes from the breakpoint value in header.css. Please make sure
// that this value is in sync with header.css if ever changed
export const HEADER_BREAKPOINT = 848; // px
type Props = { type Props = {
+showMobileNav: boolean, +showMobileNav: boolean,
+setShowMobileNav: SetState<boolean>, +setShowMobileNav: SetState<boolean>,
}; };
function Header(props: Props): React.Node { function Header(props: Props): React.Node {
const { showMobileNav, setShowMobileNav } = props; const { showMobileNav, setShowMobileNav } = props;
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines