[native] Normalize Android MarkdownLink behavior to match iOS
ClosedPublic
Actions

Authored by ashoat on Nov 30 2022, 4:11 AM.

Details

Reviewers

rohan
atul
ginsu
michal

Commits

rCOMM7988ebdc2edd: [native] Normalize Android MarkdownLink behavior to match iOS

Test Plan

I tested this on iOS and Android while pressing all over a message, before and after opening the modal. See attached video in previous diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 30 2022, 4:11 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 30 2022, 4:11 AM

ashoat added a parent revision: D5764: [native] Render second TextMessage with all Texts pressable when markdownHasPressable.Nov 30 2022, 4:11 AM

Harbormaster completed remote builds in B13863: Diff 18987.Nov 30 2022, 4:24 AM

ashoat requested review of this revision.Nov 30 2022, 4:24 AM

Links seem to be working well, I used the same tests that you used in the demo.

This revision is now accepted and ready to land.Nov 30 2022, 7:02 PM

Closed by commit rCOMM7988ebdc2edd: [native] Normalize Android MarkdownLink behavior to match iOS. · Explain WhyNov 30 2022, 7:10 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7988ebdc2edd: [native] Normalize Android MarkdownLink behavior to match iOS.

Revision Contents
Changeset List

Path

Size

native/

chat/

text-message.react.js

12 lines

markdown/

markdown-link-context.js

1 line

markdown-link.react.js

38 lines

Diff 18987

View Options

native/chat/text-message.react.js

View Options

native/markdown/markdown-link-context.js

View Options

native/markdown/markdown-link.react.js

[native] Normalize Android MarkdownLink behavior to match iOSClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18987

native/chat/text-message.react.js

native/markdown/markdown-link-context.js

native/markdown/markdown-link.react.js

[native] Normalize Android MarkdownLink behavior to match iOS
ClosedPublic
Actions

Revision Contents
Changeset List