[lib] introduced rawMessageInfoFromMessageData function to reaction message spec
ClosedPublic
Actions

Authored by ginsu on Dec 2 2022, 3:04 PM.

Details

Reviewers

atul
tomek
rohan

Commits

rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec

Summary

introduced rawMessageInfoFromMessageData function to reaction message spec. rawMessageInfoFromMessageData converts the ReactionMessageData into a RawReactionMessageInfo

Depends on D5690
Linear Task: ENG-2245

Test Plan

Ran web and mobile app locally and nothing crashes/will be doing more tests on this message spec in subsequent diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Dec 2 2022, 3:04 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 2 2022, 3:04 PM

ginsu edited the summary of this revision. (Show Details)Dec 2 2022, 3:05 PM

ginsu added reviewers: atul, tomek, rohan.

ginsu added a parent revision: D5690: [lib] introduced reaction message spec boilerplate.

Harbormaster completed remote builds in B13955: Diff 19121.Dec 2 2022, 3:15 PM

ginsu requested review of this revision.Dec 2 2022, 3:15 PM

tomek accepted this revision.Dec 6 2022, 6:06 AM

rohan accepted this revision.Dec 7 2022, 10:01 AM

atul accepted this revision.Dec 7 2022, 11:47 AM

This revision is now accepted and ready to land.Dec 7 2022, 11:47 AM

rebase before landing

Harbormaster completed remote builds in B14188: Diff 19411.Dec 15 2022, 12:20 PM

Closed by commit rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec (authored by ginsu). · Explain WhyDec 15 2022, 12:24 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM45beae3d9b2f: [lib] introduced rawMessageInfoFromMessageData function to reaction message spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

8 lines

Diff 19121

View Options

lib/shared/messages/reaction-message-spec.js

Show All 27 Lines
import {		import {
fullStateSyncActionType,		fullStateSyncActionType,
incrementalStateSyncActionType,		incrementalStateSyncActionType,
} from '../types/socket-types.js';		} from '../types/socket-types.js';
import { updateTypes } from '../types/update-types-enum.js';		import { updateTypes } from '../types/update-types-enum.js';
import { processUpdatesActionType } from '../types/update-types.js';		import { processUpdatesActionType } from '../types/update-types.js';
import type { CurrentUserInfo, UserStore } from '../types/user-types.js';		import type { CurrentUserInfo, UserStore } from '../types/user-types.js';
import { setNewSessionActionType } from '../utils/action-utils.js';		import { setNewSessionActionType } from '../utils/action-utils.js';
		import { getMessageForException } from '../utils/errors.js';
		import { assertObjectsAreEqual } from '../utils/objects.js';

function reduceCurrentUserInfo(		function reduceCurrentUserInfo(
state: ?CurrentUserInfo,		state: ?CurrentUserInfo,
action: BaseAction,		action: BaseAction,
): ?CurrentUserInfo {		): ?CurrentUserInfo {
if (		if (
action.type === logInActionTypes.success \|\|		action.type === logInActionTypes.success \|\|
action.type === siweAuthActionTypes.success \|\|		action.type === siweAuthActionTypes.success \|\|
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines	if (state?.settings) {
};		};
}		}
} else if (action.type === resetUserStateActionType) {		} else if (action.type === resetUserStateActionType) {
state = state && state.anonymous ? state : null;		state = state && state.anonymous ? state : null;
}		}
return state;		return state;
}		}

		// eslint-disable-next-line no-unused-vars
		function assertUserStoresAreEqual(
		processedUserStore: UserStore,
		expectedUserStore: UserStore,
		location: string,
		onStateDifference: (message: string) => mixed,
		) {
		try {
		assertObjectsAreEqual(
		processedUserStore,
		expectedUserStore,
		`UserStore - ${location}`,
		);
		} catch (e) {
		const message = `Error processing UserStore ops ${
		kamilAuthorUnsubmitted Done Inline Actions `UserStore` here is probably redundant (look at screenshots) kamil: `UserStore` here is probably redundant (look at screenshots)
		getMessageForException(e) ?? '{no exception message}'
		}`;
		onStateDifference(message);
		}
		}

function reduceUserInfos(		function reduceUserInfos(
state: UserStore,		state: UserStore,
action: BaseAction,		action: BaseAction,
		// eslint-disable-next-line no-unused-vars
		kamilAuthorUnsubmitted Done Inline Actions I'll remove those in the next diff (here and line 125) kamil: I'll remove those in the next diff (here and line 125)
		onStateDifference: (message: string) => mixed,
): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] {		): [UserStore, $ReadOnlyArray<UserInconsistencyReportCreationRequest>] {
if (		if (
action.type === joinThreadActionTypes.success \|\|		action.type === joinThreadActionTypes.success \|\|
action.type === newThreadActionTypes.success		action.type === newThreadActionTypes.success
) {		) {
const newUserInfos = _keyBy(userInfo => userInfo.id)(		const newUserInfos = _keyBy(userInfo => userInfo.id)(
action.payload.userInfos,		action.payload.userInfos,
);		);
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines

[lib] introduced rawMessageInfoFromMessageData function to reaction message specClosedPublicActions