Paths

Table of Contentst

[native] Fix ESLint issues after landing of React Native 0.70 stack
ClosedPublic
Actions

Authored by ashoat on Dec 20 2022, 12:39 PM.

Details

Reviewers

atul
• jon
ginsu
varun

Commits

rCOMM412a057d30a4: [native] Fix ESLint issues after landing of React Native 0.70 stack

Summary

Not sure why Buildkite CI wasn't picking these up, but GitHub Actions CI did.

All of these changes were generated by running eslint . --fix --max-warnings=0.

Test Plan

eslint . --max-warnings=0

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 20 2022, 12:39 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 20 2022, 12:39 PM

ashoat mentioned this in D5955: [native] Add "or" horizontal rule between SIWE and existing login.Dec 20 2022, 12:49 PM

Harbormaster completed remote builds in B14580: Diff 19881.Dec 20 2022, 12:53 PM

ashoat requested review of this revision.Dec 20 2022, 12:53 PM

ginsu accepted this revision.Dec 20 2022, 1:14 PM

This revision is now accepted and ready to land.Dec 20 2022, 1:14 PM

Closed by commit rCOMM412a057d30a4: [native] Fix ESLint issues after landing of React Native 0.70 stack (authored by ashoat). · Explain WhyDec 20 2022, 1:20 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM412a057d30a4: [native] Fix ESLint issues after landing of React Native 0.70 stack.

Not sure why Buildkite CI wasn't picking these up, but GitHub Actions CI did.

That's bad, will create a task.

https://linear.app/comm/issue/ENG-2505/investigate-why-buildkite-ci-didnt-pick-up-eslint-issues

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

2 lines

panel-components.react.js

2 lines

calendar/

entry.react.js

2 lines

loading-indicator.react.js

2 lines

chat/

chat-input-bar.react.js

2 lines

chat-thread-list-see-more-sidebars.react.js

2 lines

chat-thread-list.react.js

2 lines

composed-message.react.js

2 lines

inline-multimedia.react.js

4 lines

message-list-header-title.react.js

2 lines

new-messages-pill.react.js

2 lines

relationship-prompt.react.js

2 lines

settings/

color-selector-modal.react.js

2 lines

compose-subchannel-modal.react.js

2 lines

thread-settings-list-action.react.js

4 lines

swipeable-message.react.js

2 lines

swipeable-thread.react.js

2 lines

thread-settings-button.react.js

2 lines

components/

action-row.react.js

4 lines

thread-ancestors-label.react.js

2 lines

thread-ancestors.react.js

2 lines

thread-icon.react.js

2 lines

crash.react.js

2 lines

media/

camera-modal.react.js

2 lines

media-gallery-media.react.js

4 lines

send-media-button.react.js

2 lines

video-playback-modal.react.js

2 lines

root.react.js

2 lines

themes/

fonts.js

4 lines

Diff 19885

View Options

native/account/logged-out-modal.react.js

View Options

native/account/panel-components.react.js

View Options

native/calendar/entry.react.js

View Options

native/calendar/loading-indicator.react.js

View Options

native/chat/chat-input-bar.react.js

View Options

native/chat/chat-thread-list-see-more-sidebars.react.js

View Options

native/chat/chat-thread-list.react.js

View Options

native/chat/composed-message.react.js

View Options

native/chat/inline-multimedia.react.js

View Options

native/chat/message-list-header-title.react.js

View Options

native/chat/new-messages-pill.react.js

View Options

native/chat/relationship-prompt.react.js

View Options

native/chat/settings/color-selector-modal.react.js

View Options

native/chat/settings/compose-subchannel-modal.react.js

View Options

native/chat/settings/thread-settings-list-action.react.js

View Options

native/chat/swipeable-message.react.js

View Options

native/chat/swipeable-thread.react.js

View Options

native/chat/thread-settings-button.react.js

View Options

native/components/action-row.react.js

View Options

native/components/thread-ancestors-label.react.js

View Options

native/components/thread-ancestors.react.js

View Options

native/components/thread-icon.react.js

View Options

native/crash.react.js

View Options

native/media/camera-modal.react.js

View Options

native/media/media-gallery-media.react.js

View Options

native/media/send-media-button.react.js

View Options

native/media/video-playback-modal.react.js

View Options

native/root.react.js

View Options

[native] Fix ESLint issues after landing of React Native 0.70 stackClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19885

native/account/logged-out-modal.react.js

native/account/panel-components.react.js

native/calendar/entry.react.js

native/calendar/loading-indicator.react.js

native/chat/chat-input-bar.react.js

native/chat/chat-thread-list-see-more-sidebars.react.js

native/chat/chat-thread-list.react.js

native/chat/composed-message.react.js

native/chat/inline-multimedia.react.js

native/chat/message-list-header-title.react.js

native/chat/new-messages-pill.react.js

native/chat/relationship-prompt.react.js

native/chat/settings/color-selector-modal.react.js

native/chat/settings/compose-subchannel-modal.react.js

native/chat/settings/thread-settings-list-action.react.js

native/chat/swipeable-message.react.js

native/chat/swipeable-thread.react.js

native/chat/thread-settings-button.react.js

native/components/action-row.react.js

native/components/thread-ancestors-label.react.js

native/components/thread-ancestors.react.js

native/components/thread-icon.react.js

native/crash.react.js

native/media/camera-modal.react.js

native/media/media-gallery-media.react.js

native/media/send-media-button.react.js

native/media/video-playback-modal.react.js

native/root.react.js

native/themes/fonts.js

[native] Fix ESLint issues after landing of React Native 0.70 stack
ClosedPublic
Actions

Revision Contents
Changeset List