Paths

Table of Contentst

Differential D6382

[backup-service] Rename 'GetClient' to 'BlobDownloader'
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 2:00 PM

	Unknown Object (File)
	Fri, Nov 8, 5:02 AM

	Unknown Object (File)
	Fri, Nov 8, 5:02 AM

	Unknown Object (File)
	Fri, Nov 8, 3:04 AM

	Unknown Object (File)
	Fri, Nov 8, 3:04 AM

	Unknown Object (File)
	Fri, Nov 8, 3:04 AM

	Unknown Object (File)
	Fri, Nov 8, 3:04 AM

	Unknown Object (File)
	Oct 11 2024, 9:23 PM

View All 100 Files

Subscribers

Details

Reviewers

varun
• jon
michal
tomek

Commits

rCOMM0e95d2c872ce: [backup-service] Rename 'GetClient' to 'BlobDownloader'

Summary

Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance

Renamed GetClient to BlobDownloader, because this name is more accurate - these instances are not clients, but rather single RPC call instances. Also, old name could easily be confused with actual Blob Client instance, introduced in further diffs.

Test Plan

Backup service compiles and starts.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 25 2023, 2:11 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 25 2023, 2:11 AM

bartek added a child revision: D6383: [backup-service] Rename 'PutClient' to 'BlobUploader'.Jan 25 2023, 2:13 AM

Harbormaster completed remote builds in B15622: Diff 21296.Jan 25 2023, 2:25 AM

bartek published this revision for review.Jan 25 2023, 2:40 AM

tomek accepted this revision.Jan 26 2023, 4:10 AM

This revision is now accepted and ready to land.Jan 26 2023, 4:10 AM

Closed by commit rCOMM0e95d2c872ce: [backup-service] Rename 'GetClient' to 'BlobDownloader' (authored by bartek). · Explain WhyJan 31 2023, 2:23 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM0e95d2c872ce: [backup-service] Rename 'GetClient' to 'BlobDownloader'.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

blob/

	downloader.rs
	get_client.rs

12 lines

4 lines

service/

handlers/

14 lines

Diff 21296

services/backup/src/blob/downloader.rs

Loading...

services/backup/src/blob/get_client.rs

Loading...

services/backup/src/blob/mod.rs

Loading...

services/backup/src/service/handlers/pull_backup.rs

Loading...