[services][feature-flags] Introduce map and i32 parsing
ClosedPublic
Actions

Authored by tomek on Feb 23 2023, 7:27 AM.

Details

Reviewers

michal
bartek
• jon
varun

Commits

rCOMM96d9a7b0315c: [services][feature-flags] Introduce map and i32 parsing

Summary

We have to introduce a function that parses strings into numbers, because map keys in Dynamo are plain strings instead of AttributeValues. This affects what we store in DBItemError - now it is either AttributeValue or a String.

Depends on D6854

Test Plan

Tested with the rest of the stack.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Feb 23 2023, 7:27 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 23 2023, 7:27 AM

tomek added inline comments.Feb 23 2023, 7:28 AM

services/feature-flags/src/database.rs
40–44	This is copied from other services. I had to remove it from the previous diff as this case couldn't be matched.

Harbormaster completed remote builds in B16828: Diff 23005.Feb 23 2023, 7:43 AM

tomek requested review of this revision.Feb 23 2023, 7:43 AM

tomek added a child revision: D6856: [services][feature-flags] Parse feature flags response from DynamoDB.Feb 23 2023, 8:14 AM

bartek requested changes to this revision.Feb 24 2023, 1:41 AM

bartek added inline comments.

services/feature-flags/src/database.rs
101–109	Don't you want to distinguish between `IncorrectType` and `Missing`, the same way as in `parse_{string,bool}_attribute`? If this is done deliberately, just let me know
116–123	Wouldn't it work this way? Or are error types incompatible?