Query the db, transform the result and return it as a response from an endpoint.
Depends on D6861
Details
Details
Send GET request and check it the response is correctly read from AWS.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- flags
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/feature-flags/src/service.rs | ||
|---|---|---|
| 35–54 | I'd prefer to return early (pasted code here instead of suggestion because it was so unreadable) let platform = match query.platform.as_str() { "iOS" => Platform::IOS, "Android" => Platform::ANDROID, _ => { return HttpResponse::BadRequest().finish() }, }; match Self::enabled_features_set( client.get_ref(), platform, query.code_version, query.is_staff, ) .await { Ok(features) => HttpResponse::Ok() .body(features.into_iter().collect::<Vec<_>>().join(", ")), _ => HttpResponse::InternalServerError().finish(), } | |
| 36–37 | Is it case-sensitive? And should URLs be? | |
| 49–50 | I'm wondering if this isn't more readable than a one-liner. Up to you | |
| 50 |
| |
| services/feature-flags/src/service.rs | ||
|---|---|---|
| 36–37 | Query part of url is case-sensitive. I guess we can make the check on service side case-insensitive, just for the convenience. | |
| 49–50 | Agree, it's more readable. | |
| 50 | Makes sense! The docs don't mention that the content is set automatically, so I added it explicitly. | |