Introduce Docker config so that the service can be run in a container.
Depends on D6862
Differential D6886
[services][feature-flags] Dockerize the service tomek on Feb 24 2023, 8:15 AM. Authored by Tags None Referenced Files
Details Introduce Docker config so that the service can be run in a container. Depends on D6862 Run the container locally. Using Docker Desktop terminal send a GET to the service and check if it returns a response based on AWS DynamoDB content. Haven't figured out how to send a request from host, but verifying that is the next step.
Diff Detail
Event TimelineComment Actions Looks good to me, but letting @jon take a look
Not sure what you exactly mean, but docker-compose exposes the service port to host, so you should be able to simply yarn run-feature-flags-service-in-sandbox # in a separate terminal curl "http://localhost:50055/features?platform=..." # etc Comment Actions Looks fine to me. The canonical way to handle args would be to use case for the positional arguments, then continue to consume the input with shift. But that would be more effort than just assuming we will have 1 or 2 arguments. Comment Actions
That's exactly what I've done, but I have to figure out why it didn't work. @jon could you explain a little bit what do you mean by
Which part of the code does it correspond to? Comment Actions
The issue was caused by a fact that I was using localhost instead of 0.0.0.0. When running the service locally, there's no difference. But when a service is run within a container, the localhost doesn't work properly.
|