Page MenuHomePhabricator
Differential D6957

[native] Fix broken error handling in getUserPublicKey
ClosedPublic
Actions

Authored by ashoat on Mar 6 2023, 11:01 AM.
Tags
None
Referenced Files
F1780430: D6957.diff
Sat, May 18, 4:43 AM
Unknown Object (File)
Sat, May 11, 10:28 AM
Unknown Object (File)
Sat, May 11, 10:28 AM
Unknown Object (File)
Sat, May 11, 10:28 AM
Unknown Object (File)
Sat, May 11, 10:28 AM
Unknown Object (File)
Mon, Apr 29, 11:31 AM
Unknown Object (File)
Sun, Apr 28, 9:03 AM
Unknown Object (File)
Sun, Apr 28, 9:03 AM
View All 56 Files
Subscribers
tomek

Details

Reviewers
atul
marcin
Commits
rCOMM55ea22ac5c60: [native] Fix broken error handling in getUserPublicKey
Summary

Context here and on Linear.

Test Plan

Repro the issue and see a promise rejection warning YellowBox instead of the app crashing on log-in

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 6 2023, 11:01 AM
Herald added a subscriber: tomek. · View Herald TranscriptMar 6 2023, 11:01 AM
Harbormaster completed remote builds in B17129: Diff 23467.Mar 6 2023, 11:17 AM
ashoat requested review of this revision.Mar 6 2023, 11:17 AM
atul accepted this revision.Mar 6 2023, 11:21 AM
atul added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
843–884 ↗(On Diff #23467)

Not a huge fan of having a single error that gets repurposed as we get deeper in the indentation and just the amount of indentation generally... but seems like the way we're handing things in CommCoreModule so probably fine for now.

This revision is now accepted and ready to land.Mar 6 2023, 11:21 AM
ashoat added inline comments.Mar 6 2023, 11:22 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
843–884 ↗(On Diff #23467)

I don't like it either, but don't have time to do anything better right now

ashoat added a child revision: D6958: [native] Move CommSecureStore::get to main thread to avoid JNI crash.Mar 6 2023, 11:55 AM
Closed by commit rCOMM55ea22ac5c60: [native] Fix broken error handling in getUserPublicKey (authored by ashoat). · Explain WhyMar 6 2023, 1:25 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM55ea22ac5c60: [native] Fix broken error handling in getUserPublicKey.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
63 lines

Diff 23471

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...