[native] introduce EditAvatar component
ClosedPublic
Actions

Authored by ginsu on Apr 13 2023, 3:32 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMMdf347498d65f: [native] introduce EditAvatar component

Summary

EditAvatar is a component that handles all the common logic between editing a user and thread avatar. Following diffs will handle the introduction of the logic for things like the action sheet, image picker, camera modal, loading, etc. in this component

Depends on D7324

Test Plan

I am able to navigate to EmojiAvatarCreation using this new component from both the thread settings and profile. Please watch the demo video to see the changes I made

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 13 2023, 3:32 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 3:32 PM

remove extra comment

ginsu edited the summary of this revision. (Show Details)Apr 13 2023, 3:40 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, ashoat.

ginsu added a parent revision: D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.

ginsu attached a referenced file: F484428: Screen Recording 2023-04-13 at 6.39.05 PM.mov. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B18353: Diff 25147.Apr 13 2023, 3:50 PM

Harbormaster completed remote builds in B18354: Diff 25148.

ginsu requested review of this revision.Apr 13 2023, 3:51 PM

It's cool how the ThreadAvatar / ChildAvatar is a child of EditAvatar

native/components/edit-avatar.react.js
43 ↗	(On Diff #25148)	Realize this is just a refactor diff, but I think we should `TouchableOpacity` or something instead of `TouchableWithoutFeedback`