Page MenuHomePhabricator
Differential D7438

[native] introduce EditAvatar component
ClosedPublic
Actions

Authored by ginsu on Apr 13 2023, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 4:27 AM
Unknown Object (File)
Wed, Mar 26, 1:32 PM
Unknown Object (File)
Sat, Mar 15, 2:52 PM
Unknown Object (File)
Mar 9 2025, 5:23 AM
Unknown Object (File)
Mar 6 2025, 1:32 PM
Unknown Object (File)
Mar 4 2025, 2:52 AM
Unknown Object (File)
Mar 4 2025, 2:52 AM
Unknown Object (File)
Mar 4 2025, 2:52 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMdf347498d65f: [native] introduce EditAvatar component
Summary

EditAvatar is a component that handles all the common logic between editing a user and thread avatar. Following diffs will handle the introduction of the logic for things like the action sheet, image picker, camera modal, loading, etc. in this component

Depends on D7324

Test Plan

I am able to navigate to EmojiAvatarCreation using this new component from both the thread settings and profile. Please watch the demo video to see the changes I made

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 13 2023, 3:32 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 3:32 PM
ginsu updated this revision to Diff 25148.Apr 13 2023, 3:33 PM

remove extra comment

ginsu edited the summary of this revision. (Show Details)Apr 13 2023, 3:40 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu added a parent revision: D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.
ginsu attached a referenced file: F484428: Screen Recording 2023-04-13 at 6.39.05 PM.mov. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B18353: Diff 25147.Apr 13 2023, 3:50 PM
Harbormaster completed remote builds in B18354: Diff 25148.
ginsu requested review of this revision.Apr 13 2023, 3:51 PM
ashoat accepted this revision.Apr 14 2023, 6:42 AM

It's cool how the ThreadAvatar / ChildAvatar is a child of EditAvatar

native/components/edit-avatar.react.js
43 ↗(On Diff #25148)

Realize this is just a refactor diff, but I think we should TouchableOpacity or something instead of TouchableWithoutFeedback

This revision is now accepted and ready to land.Apr 14 2023, 6:42 AM
ginsu updated this revision to Diff 25176.Apr 14 2023, 11:14 AM

address comments and rebase before landing

Harbormaster completed remote builds in B18378: Diff 25176.Apr 14 2023, 11:32 AM
Closed by commit rCOMMdf347498d65f: [native] introduce EditAvatar component (authored by ginsu). · Explain WhyApr 14 2023, 11:37 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdf347498d65f: [native] introduce EditAvatar component.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
72 lines
components/
68 lines
profile/
57 lines

Diff 25183

View Options

native/chat/settings/thread-settings-avatar.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net
View Options

native/components/edit-avatar.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net
View Options

native/profile/profile-screen.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net