[native] Change hasMinCodeVersion for edit message type
ClosedPublic
Actions

Authored by • kuba on Apr 25 2023, 7:00 AM.

Details

Reviewers

ashoat
atul

Commits

rCOMMaf401cba8887: [native] Change hasMinCodeVersion for edit message type

Summary

Changed min code version in edit-message-spec.js.

Test Plan

Can't really test it

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.Apr 25 2023, 7:00 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 7:00 AM

• kuba added a parent revision: D7518: [native][fix] Fixed message height warnings on Android.Apr 25 2023, 7:00 AM

Harbormaster completed remote builds in B18739: Diff 25677.Apr 25 2023, 7:17 AM

• kuba requested review of this revision.Apr 25 2023, 7:17 AM

I think this is right, but would like @atul to confirm

Yes this looks right, but are all the changes that are necessary for release landed? As in, if I were to make a release just off of this diff would things be good to go?

For example, do we have a unshimClientDB(...) migration in persist.js? Have we added this message type to localUnshimTypes? Not seeing anything on master or Phabricator, but feel free to re-request review if I'm missing something.

This revision now requires changes to proceed.Apr 25 2023, 10:25 AM