Page MenuHomePhabricator
Differential D7445

[native] Added message editing
ClosedPublic
Actions

Authored by • kuba on Apr 14 2023, 1:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 17 2025, 2:45 PM
Unknown Object (File)
Mar 17 2025, 2:45 PM
Unknown Object (File)
Mar 17 2025, 2:44 PM
Unknown Object (File)
Mar 17 2025, 2:36 PM
Unknown Object (File)
Mar 12 2025, 3:34 PM
Unknown Object (File)
Feb 27 2025, 1:10 PM
Unknown Object (File)
Feb 25 2025, 6:24 PM
Unknown Object (File)
Feb 25 2025, 4:50 AM
View All 99 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
Commits
rCOMMfba08e783972: [native] Added message editing
Summary

After pressing send button in edit mode, the message will be edited with new content.

Test Plan

Tested on iOS, in edit mode:

  • modified the content, pressed the sent button (the message has been edited, exited edit mode, restored draft),
  • modified the content, pressed the sent button with disabled keyserver (an alert appeared, remained in edit mode):

Screenshot 2023-04-14 at 10.21.42.png (762×734 px, 174 KB)

  • left the content the same, pressed the sent button (exited edit mode without alert, restored the draft).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
chat/
45 lines

Diff 25669

View Options

native/chat/chat-input-bar.react.js

#include "CommCoreModule.h" #include "CommCoreModule.h"
#include "../CryptoTools/DeviceID.h" #include "../CryptoTools/DeviceID.h"
#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h" #include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"
#include "BaseDataStore.h" #include "BaseDataStore.h"
#include "DatabaseManager.h" #include "DatabaseManager.h"
#include "InternalModules/GlobalDBSingleton.h" #include "InternalModules/GlobalDBSingleton.h"
#include "InternalModules/RustPromiseManager.h"
#include "NativeModuleUtils.h" #include "NativeModuleUtils.h"
#include "TerminateApp.h" #include "TerminateApp.h"
#include "lib.rs.h"
#include <ReactCommon/TurboModuleUtils.h> #include <ReactCommon/TurboModuleUtils.h>
#include <folly/dynamic.h> #include <folly/dynamic.h>
#include <folly/json.h> #include <folly/json.h>
#include <future> #include <future>
namespace comm { namespace comm {
▲ Show 20 Lines • Show All 782 Lines • ▼ Show 20 Lines
bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) { bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
return DatabaseManager::checkIfDatabaseNeedsDeletion(); return DatabaseManager::checkIfDatabaseNeedsDeletion();
} }
void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) { void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
DatabaseManager::reportDBOperationsFailure(); DatabaseManager::reportDBOperationsFailure();
} }
jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
return createPromiseAsJSIValue(
rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityGenerateNonce(currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
jsi::Value CommCoreModule::registerUser(
jsi::Runtime &rt,
jsi::String username,
jsi::String password,
jsi::String keyPayload,
jsi::String keyPayloadSignature,
jsi::String contentPrekey,
jsi::String contentPrekeySignature,
jsi::String notifPrekey,
jsi::String notifPrekeySignature,
jsi::Array contentOneTimeKeys,
jsi::Array notifOneTimeKeys) {
return createPromiseAsJSIValue(
rt,
[this,
&username,
&password,
&keyPayload,
&keyPayloadSignature,
&contentPrekey,
&contentPrekeySignature,
&notifPrekey,
&notifPrekeySignature,
&contentOneTimeKeys,
&notifOneTimeKeys](
jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityRegisterUser(
jsiStringToRustString(username, innerRt),
jsiStringToRustString(password, innerRt),
jsiStringToRustString(keyPayload, innerRt),
jsiStringToRustString(keyPayloadSignature, innerRt),
jsiStringToRustString(contentPrekey, innerRt),
jsiStringToRustString(contentPrekeySignature, innerRt),
jsiStringToRustString(notifPrekey, innerRt),
jsiStringToRustString(notifPrekeySignature, innerRt),
jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
jsi::Value CommCoreModule::loginPasswordUser(
jsi::Runtime &rt,
jsi::String username,
jsi::String password,
jsi::String keyPayload,
jsi::String keyPayloadSignature,
jsi::String contentPrekey,
jsi::String contentPrekeySignature,
jsi::String notifPrekey,
jsi::String notifPrekeySignature,
jsi::Array contentOneTimeKeys,
jsi::Array notifOneTimeKeys) {
return createPromiseAsJSIValue(
rt,
[this,
&username,
&password,
&keyPayload,
&keyPayloadSignature,
&contentPrekey,
&contentPrekeySignature,
&notifPrekey,
&notifPrekeySignature,
&contentOneTimeKeys,
&notifOneTimeKeys](
jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityLoginPasswordUser(
jsiStringToRustString(username, innerRt),
jsiStringToRustString(password, innerRt),
jsiStringToRustString(keyPayload, innerRt),
jsiStringToRustString(keyPayloadSignature, innerRt),
jsiStringToRustString(contentPrekey, innerRt),
jsiStringToRustString(contentPrekeySignature, innerRt),
jsiStringToRustString(notifPrekey, innerRt),
jsiStringToRustString(notifPrekeySignature, innerRt),
jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
jsi::Value CommCoreModule::loginWalletUser(
jsi::Runtime &rt,
jsi::String siweMessage,
jsi::String siweSignature,
jsi::String keyPayload,
jsi::String keyPayloadSignature,
jsi::String contentPrekey,
jsi::String contentPrekeySignature,
jsi::String notifPrekey,
jsi::String notifPrekeySignature,
jsi::Array contentOneTimeKeys,
jsi::Array notifOneTimeKeys,
jsi::String socialProof) {
return createPromiseAsJSIValue(
rt,
[this,
&siweMessage,
&siweSignature,
&keyPayload,
&keyPayloadSignature,
&contentPrekey,
&contentPrekeySignature,
&notifPrekey,
&notifPrekeySignature,
&contentOneTimeKeys,
&notifOneTimeKeys,
&socialProof](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error;
try {
auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt);
identityLoginWalletUser(
jsiStringToRustString(siweMessage, innerRt),
jsiStringToRustString(siweSignature, innerRt),
jsiStringToRustString(keyPayload, innerRt),
jsiStringToRustString(keyPayloadSignature, innerRt),
jsiStringToRustString(contentPrekey, innerRt),
jsiStringToRustString(contentPrekeySignature, innerRt),
jsiStringToRustString(notifPrekey, innerRt),
jsiStringToRustString(notifPrekeySignature, innerRt),
jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
jsiStringToRustString(socialProof, innerRt),
currentID);
} catch (const std::exception &e) {
error = e.what();
};
});
}
} // namespace comm } // namespace comm