Page MenuHomePhabricator
Differential D7484

[native] Scrolling to the edited message
ClosedPublic
Actions

Authored by • kuba on Apr 18 2023, 3:17 AM.
Tags
None
Referenced Files
F2110251: D7484.id25675.diff
Tue, Jun 25, 7:10 PM
Unknown Object (File)
Mon, Jun 24, 10:40 AM
Unknown Object (File)
Mon, Jun 24, 7:20 AM
Unknown Object (File)
Thu, Jun 20, 12:35 PM
Unknown Object (File)
Fri, Jun 14, 7:12 AM
Unknown Object (File)
Thu, Jun 13, 8:12 AM
Unknown Object (File)
Fri, Jun 7, 1:46 AM
Unknown Object (File)
Mon, Jun 3, 7:23 AM
View All 44 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
Commits
rCOMM45b7fa231e0b: [native] Scrolling to the edited message
Summary

Added ability to scroll to the currently edited message.

Test Plan

Tested only on iOS (waiting for android to compile, but have problems with it). Entered edit mode.

  1. Pressed the preview of the currently edited message. The list scrolled to the edited message. Tested a few times.
  1. Artificial changed the key of the message, so it doesn't exist in the list. Pressed preview of the currently edited message, the warning appeared in the console as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• kuba created this revision.Apr 18 2023, 3:17 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 18 2023, 3:17 AM
• kuba added a parent revision: D7448: [native] Disable typeahead and media buttons in edit mode.Apr 18 2023, 3:26 AM
• kuba added inline comments.
native/chat/chat-list.react.js
286 ↗(On Diff #25256)

I created it this way, because:

flatList.scrollToItem({ item: key, animated: true });

didn't work.

Harbormaster completed remote builds in B18441: Diff 25256.Apr 18 2023, 3:36 AM
• kuba requested review of this revision.Apr 18 2023, 3:36 AM
• kuba planned changes to this revision.Apr 18 2023, 3:46 AM

On Android TouchableOpacity caused a visual glitch.

• kuba updated this revision to Diff 25257.Apr 18 2023, 4:52 AM

Fixed glitch on Android, swapped View and TouchableOpacity order

Harbormaster completed remote builds in B18442: Diff 25257.Apr 18 2023, 5:10 AM
• kuba added a child revision: D7520: [native] Handle entering edit mode when already in edit mode.Apr 19 2023, 4:24 AM
michal accepted this revision.Apr 20 2023, 5:18 AM

Looks good to me

This revision is now accepted and ready to land.Apr 20 2023, 5:18 AM
Closed by commit rCOMM45b7fa231e0b: [native] Scrolling to the edited message (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:46 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM45b7fa231e0b: [native] Scrolling to the edited message.

Revision Contents
Changeset List

PathSize
native/
chat/
29 lines
31 lines
input/
20 lines
3 lines

Diff 25675

View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/chat-list.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

native/input/input-state.js

Loading...