Page MenuHomePhabricator
Differential D7349

[native] Add alert when exiting edit mode by clicking the exit button
ClosedPublic
Actions

Authored by • kuba on Apr 7 2023, 7:23 AM.
Tags
None
Referenced Files
F3179809: D7349.id.diff
Fri, Nov 8, 3:36 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 4:48 AM
Unknown Object (File)
Tue, Nov 5, 2:43 AM
Unknown Object (File)
Tue, Nov 5, 2:42 AM
Unknown Object (File)
Mon, Oct 28, 12:59 PM
Unknown Object (File)
Sep 28 2024, 6:29 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
Commits
rCOMM032d0d7fc9a1: [native] Add alert when exiting edit mode by clicking the exit button
Summary

We want to make sure, that the user wanted to close the editing panel. Created a discard edited changes modal. It displays only if there are some changes in the message.

Test Plan

Run the app on iOS.

  1. Selected message to edit. Edited it. Pressed exit edit mode button. The alert appears.
  2. Checked if the alert only appears if there are some changes in the message.
  3. Checked if in both scenarios we restore the message draft after exiting edit mode.

Screenshot 2023-04-12 at 14.57.07.png (374×1 px, 227 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• kuba created this revision.Apr 7 2023, 7:23 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 7:23 AM
• kuba added a parent revision: D7347: [native] Preserve the draft for ChatInputBar after leaving edit mode.Apr 7 2023, 7:23 AM
• kuba edited the summary of this revision. (Show Details)Apr 7 2023, 7:27 AM
• kuba edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B18098: Diff 24798.Apr 7 2023, 7:50 AM
• kuba requested review of this revision.Apr 7 2023, 7:50 AM
inka accepted this revision.Apr 11 2023, 4:06 AM
inka added inline comments.
native/chat/chat-input-bar.react.js
801 ↗(On Diff #24798)

I think we omit the "the" in names

This revision is now accepted and ready to land.Apr 11 2023, 4:06 AM
• kuba updated this revision to Diff 24957.Apr 11 2023, 5:01 AM

Renamed isMessageEdited function

• kuba marked an inline comment as done.Apr 11 2023, 5:01 AM
Harbormaster completed remote builds in B18221: Diff 24957.Apr 11 2023, 5:18 AM
tomek added a comment.Apr 12 2023, 2:02 AM

Could you also share a screenshot from Android?

• kuba updated this revision to Diff 25028.Apr 12 2023, 3:30 AM

Added styling to discard button

Harbormaster completed remote builds in B18267: Diff 25028.Apr 12 2023, 3:48 AM
• kuba edited the test plan for this revision. (Show Details)Apr 12 2023, 5:57 AM
In D7349#220108, @tomek wrote:

Could you also share a screenshot from Android?

Sure. Updated the test plan. I changed also Discard edit button styling to red (on iOS).

• kuba added a child revision: D7415: [lib] Change definition of useEditMessage function.Apr 13 2023, 4:27 AM
inka mentioned this in D7520: [native] Handle entering edit mode when already in edit mode.Apr 19 2023, 5:40 AM
Closed by commit rCOMM032d0d7fc9a1: [native] Add alert when exiting edit mode by clicking the exit button (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:44 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM032d0d7fc9a1: [native] Add alert when exiting edit mode by clicking the exit button.

Revision Contents
Changeset List

PathSize
native/
chat/
29 lines

Diff 25667

View Options

native/chat/chat-input-bar.react.js

Loading...