Page MenuHomePhabricator

[native] Change EditState to store messageInfo instead of only id
ClosedPublic

Authored by kuba on Apr 13 2023, 4:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 26 2024, 1:52 PM
Unknown Object (File)
May 26 2024, 10:03 AM
Unknown Object (File)
May 19 2024, 2:20 PM
Unknown Object (File)
May 5 2024, 1:27 AM
Unknown Object (File)
May 5 2024, 1:27 AM
Unknown Object (File)
May 5 2024, 12:51 AM
Unknown Object (File)
Mar 28 2024, 3:02 AM
Unknown Object (File)
Mar 28 2024, 3:02 AM
Subscribers

Details

Summary

Updated to provide messageInfo for next diff.
We need not only the id of the message but also its content. Now, we store the full messageInfo of the edited message.

Test Plan

Checked if the app still works as expected after the changes.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kuba edited the summary of this revision. (Show Details)
tomek added inline comments.
native/input/input-state.js
61 ↗(On Diff #25089)

Do we use this callback?

This revision is now accepted and ready to land.Apr 14 2023, 3:23 AM
native/input/input-state.js
61 ↗(On Diff #25089)

Yes, i.g. in this diff: https://phab.comm.dev/D7347 in the file native/chat/chat-input-bar.react.js line 798.