Page MenuHomePhabricator
Differential D7609

[native] Change hasMinCodeVersion for edit message type
ClosedPublic
Actions

Authored by • kuba on Apr 25 2023, 7:00 AM.
Tags
None
Referenced Files
F3174421: D7609.diff
Thu, Nov 7, 4:38 PM
Unknown Object (File)
Thu, Nov 7, 8:59 AM
Unknown Object (File)
Tue, Nov 5, 8:58 AM
Unknown Object (File)
Tue, Nov 5, 8:58 AM
Unknown Object (File)
Tue, Nov 5, 8:58 AM
Unknown Object (File)
Tue, Nov 5, 8:57 AM
Unknown Object (File)
Thu, Oct 31, 11:39 PM
Unknown Object (File)
Sat, Oct 26, 1:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMaf401cba8887: [native] Change hasMinCodeVersion for edit message type
Summary

Changed min code version in edit-message-spec.js.

Test Plan

Can't really test it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Apr 25 2023, 7:00 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 7:00 AM
• kuba added a parent revision: D7518: [native][fix] Fixed message height warnings on Android.Apr 25 2023, 7:00 AM
Harbormaster completed remote builds in B18739: Diff 25677.Apr 25 2023, 7:17 AM
• kuba requested review of this revision.Apr 25 2023, 7:17 AM
ashoat accepted this revision.Apr 25 2023, 10:19 AM
ashoat added 1 blocking reviewer(s): atul.

I think this is right, but would like @atul to confirm

atul requested changes to this revision.Apr 25 2023, 10:25 AM

Yes this looks right, but are all the changes that are necessary for release landed? As in, if I were to make a release just off of this diff would things be good to go?

For example, do we have a unshimClientDB(...) migration in persist.js? Have we added this message type to localUnshimTypes? Not seeing anything on master or Phabricator, but feel free to re-request review if I'm missing something.

This revision now requires changes to proceed.Apr 25 2023, 10:25 AM
• kuba updated this revision to Diff 25753.EditedApr 26 2023, 4:04 AM

Address comments. I've also changed the minVersion to match next version.

• kuba updated this revision to Diff 25754.Apr 26 2023, 4:10 AM

Updated version in persist.js

Harbormaster completed remote builds in B18797: Diff 25753.Apr 26 2023, 4:22 AM
Harbormaster completed remote builds in B18798: Diff 25754.Apr 26 2023, 4:27 AM
atul accepted this revision.Apr 26 2023, 1:13 PM
This revision is now accepted and ready to land.Apr 26 2023, 1:13 PM
Closed by commit rCOMMaf401cba8887: [native] Change hasMinCodeVersion for edit message type (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 27 2023, 1:27 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMaf401cba8887: [native] Change hasMinCodeVersion for edit message type.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
2 lines
1 line
native/
redux/
3 lines

Diff 25754

View Options

lib/shared/messages/edit-message-spec.js

Loading...
View Options

lib/shared/unshim-utils.js

Loading...
View Options

native/redux/persist.js

Loading...