Page MenuHomePhabricator
Differential D7794

[web] Add new edit message provider
ClosedPublic
Actions

Authored by • kuba on May 11 2023, 6:01 AM.
Tags
None
Referenced Files
F3375276: D7794.diff
Tue, Nov 26, 7:26 PM
Unknown Object (File)
Sat, Nov 23, 7:36 AM
Unknown Object (File)
Mon, Nov 4, 1:15 PM
Unknown Object (File)
Mon, Nov 4, 1:15 PM
Unknown Object (File)
Mon, Nov 4, 1:15 PM
Unknown Object (File)
Mon, Nov 4, 1:15 PM
Unknown Object (File)
Mon, Nov 4, 1:15 PM
Unknown Object (File)
Oct 26 2024, 11:17 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Commits
rCOMM2815fda0a332: [web] Add new edit message provider
Summary

Created a new context for message editing. Used ModalOverlay template.

Test Plan

In later diffs checked if the context works correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.May 11 2023, 6:01 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 11 2023, 6:01 AM
• kuba added a parent revision: D7793: [web] Added edit button to the Tooltip.May 11 2023, 6:01 AM
Harbormaster completed remote builds in B19288: Diff 26401.May 11 2023, 6:18 AM
• kuba requested review of this revision.May 11 2023, 6:18 AM
• kuba added a child revision: D7822: [web] Added ChatInputTextArea component.May 16 2023, 1:24 AM
michal added inline comments.May 16 2023, 11:03 AM
web/chat/edit-message-provider.js
58–63 ↗(On Diff #26401)

Is there a reason why this isn't just in the React.useMemo for the modal?

• kuba updated this revision to Diff 26577.May 17 2023, 3:20 AM
• kuba marked an inline comment as done.

Added useMemo to modalOverlay

web/chat/edit-message-provider.js
58–63 ↗(On Diff #26401)

No, added it.

Harbormaster completed remote builds in B19427: Diff 26577.May 17 2023, 3:38 AM
• kuba removed a parent revision: D7793: [web] Added edit button to the Tooltip.May 17 2023, 6:44 AM
• kuba added a child revision: D7793: [web] Added edit button to the Tooltip.
• kuba removed a child revision: D7822: [web] Added ChatInputTextArea component.May 17 2023, 7:11 AM
michal accepted this revision.May 19 2023, 2:55 AM
This revision is now accepted and ready to land.May 19 2023, 2:55 AM
Closed by commit rCOMM2815fda0a332: [web] Add new edit message provider (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 24 2023, 3:46 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM2815fda0a332: [web] Add new edit message provider.

Revision Contents
Changeset List

PathSize
web/
33 lines
chat/
81 lines

Diff 26577

View Options

web/app.react.js

Loading...
View Options

web/chat/edit-message-provider.js

Loading...