Details

Reviewers

atul
kamil

Commits

rCOMM68902e7a2704: [landing] introduce signal competitor data

Summary

This diff introduces the competitor data for signal which will be used in the competitor comparison. Right now I only have copy for Signal, but there is a Linear task to track the other competitors. As the tasks get completed, I will update the document accordingly

Depends on D8015

Test Plan

Read through carefully and will be further tested in subsequent diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 22 2023, 5:53 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 22 2023, 5:53 AM

ginsu edited the summary of this revision. (Show Details)May 22 2023, 5:55 AM

ginsu edited the summary of this revision. (Show Details)May 22 2023, 5:58 AM

ginsu added reviewers: atul, kamil.

ginsu edited the summary of this revision. (Show Details)

ginsu added inline comments.May 22 2023, 6:04 AM

landing/competitor-data.js
8–9 ↗	(On Diff #26767)	These description are for the cards
10–11 ↗	(On Diff #26767)	These descriptions are for the modal

Harbormaster completed remote builds in B19582: Diff 26767.May 22 2023, 6:12 AM

ginsu requested review of this revision.May 22 2023, 6:12 AM

ginsu added a child revision: D7905: [landing] introduce competitor feature card component.May 22 2023, 6:29 AM

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

This revision is now accepted and ready to land.May 22 2023, 8:29 AM

I'm guessing this is the copy from DES-79, in which case I wrote it. RE line lengths, I guess it's fine

landing/competitor-data.js
22 ↗	(On Diff #26767)	Typo

address comments and remove logoImageURL field (since we are using svgs now)

Assuming @ashoat has signed off on copy + we're fine with having lines extend past 80 characters since this is a "data" file vs. "code" file?

Yes this was copy and pasted directly from DES-79 (sorry should have made that super clear) and investor-data.js also had lines that extended past 80 characters so I assumed this was okay

Harbormaster completed remote builds in B19699: Diff 26912.May 23 2023, 10:04 AM

ginsu edited the summary of this revision. (Show Details)May 24 2023, 5:58 AM

ginsu added a parent revision: D7945: [landing] add size prop to logo components.

ginsu added a child revision: D8015: [landing] introduce competitor logo component.May 29 2023, 2:46 PM

ginsu removed a child revision: D7905: [landing] introduce competitor feature card component.

ginsu removed a child revision: D8015: [landing] introduce competitor logo component.May 29 2023, 4:35 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D8015: [landing] introduce competitor logo component.

ginsu removed a parent revision: D7945: [landing] add size prop to logo components.

ginsu added a child revision: D7905: [landing] introduce competitor feature card component.May 29 2023, 4:37 PM

ginsu added a child revision: D8016: [landing] introduce competitors type.

ginsu removed a child revision: D7905: [landing] introduce competitor feature card component.May 29 2023, 4:40 PM

use rsquo

Harbormaster completed remote builds in B20855: Diff 28563.Jul 10 2023, 2:50 PM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.