[lib] Make messageID in useEditMessage mandatory
ClosedPublic
Actions

Authored by • kuba on May 23 2023, 4:27 AM.

Details

Reviewers

michal
inka

Commits

rCOMM8178288a239c: [lib] Make messageID in useEditMessage mandatory

Summary

Instead of invariant we can make messageID obligatory.

Test Plan

Edit the message on web,
Edit the message on iOS,

Diff Detail

Repository

rCOMM Comm

Branch

kuba/message-editing-web

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.May 23 2023, 4:27 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 23 2023, 4:27 AM

• kuba added a parent revision: D7930: [web] Changed edit modal overlay opacity.May 23 2023, 4:27 AM

Harbormaster completed remote builds in B19656: Diff 26864.May 23 2023, 4:45 AM

• kuba requested review of this revision.May 23 2023, 4:45 AM

inka accepted this revision.May 23 2023, 7:32 AM

This revision is now accepted and ready to land.May 23 2023, 7:32 AM

Closed by commit rCOMM8178288a239c: [lib] Make messageID in useEditMessage mandatory (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 24 2023, 4:01 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM8178288a239c: [lib] Make messageID in useEditMessage mandatory.

Revision Contents
Changeset List

Path

Size

lib/

shared/

edit-messages-utils.js

5 lines

Diff 26864

View Options

lib/shared/edit-messages-utils.js

	Show All 10 Lines
	import type { AppState } from '../redux/state-types.js';			import type { AppState } from '../redux/state-types.js';
	import type { NavPlusRedux } from '../types/selector-types.js';			import type { NavPlusRedux } from '../types/selector-types.js';

	const msInHour = 60 * 60 * 1000;			const msInHour = 60 * 60 * 1000;

	const nextMessagePruneTimeSelector: (state: AppState) => ?number =			const nextMessagePruneTimeSelector: (state: AppState) => ?number =
	createSelector(			createSelector(
	(state: AppState) => state.messageStore.threads,			(state: AppState) => state.messageStore.threads,
	(threadMessageInfos: { +[id: string]: ThreadMessageInfo }): ?number => {			(state: AppState) => state.threadActivityStore,
				(
				threadMessageInfos: { +[id: string]: ThreadMessageInfo },
				threadActivityStore: ThreadActivityStore,
				): ?number => {
	let nextTime;			let nextTime;
	for (const threadID in threadMessageInfos) {			for (const threadID in threadMessageInfos) {
	const threadMessageInfo = threadMessageInfos[threadID];
	const threadPruneTime = Math.max(			const threadPruneTime = Math.max(
	threadMessageInfo.lastNavigatedTo + msInHour,			(threadActivityStore?.[threadID]?.lastNavigatedTo ?? 0) + msInHour,
	threadMessageInfo.lastPruned + msInHour * 6,			(threadActivityStore?.[threadID]?.lastPruned ?? 0) + msInHour * 6,
	);			);
	if (nextTime === undefined \|\| threadPruneTime < nextTime) {			if (nextTime === undefined \|\| threadPruneTime < nextTime) {
	nextTime = threadPruneTime;			nextTime = threadPruneTime;
	}			}
	}			}
	return nextTime;			return nextTime;
	},			},
	);			);
	Show All 33 Lines

[lib] Make messageID in useEditMessage mandatoryClosedPublicActions