Page MenuHomePhabricator
Differential D8016

[landing] introduce competitors type
ClosedPublic
Actions

Authored by ginsu on May 29 2023, 4:33 PM.
Tags
None
Referenced Files
F4948740: D8016.diff
Wed, Mar 19, 11:41 PM
Unknown Object (File)
Wed, Mar 5, 4:40 AM
Unknown Object (File)
Tue, Mar 4, 6:45 AM
Unknown Object (File)
Wed, Feb 26, 4:25 AM
Unknown Object (File)
Tue, Feb 25, 3:40 PM
Unknown Object (File)
Tue, Feb 25, 1:48 PM
Unknown Object (File)
Tue, Feb 25, 1:48 PM
Unknown Object (File)
Tue, Feb 25, 1:48 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM93feef9ace86: [landing] introduce competitors type
Summary

As I was working on addressing some feedback to competitor feedback cards, I wanted to reuse the values of competitors as a type in the competitor card component and competitor logo component. This diff creates the shared type

Depends on D7904

Test Plan

flow, everything still works

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
landing/
12 lines
3 lines

Diff 27231

View Options

landing/competitor-data.js

// @flow // @flow
import fs from 'fs'; import fs from 'fs';
import { policyTypes } from 'lib/facts/policies.js'; import { policyTypes } from 'lib/facts/policies.js';
import { messageTypes } from 'lib/types/message-types.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { processMessagesInDBForSearch } from '../database/search-utils.js'; import { processMessagesInDBForSearch } from '../database/search-utils.js';
import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js'; import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js';
const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([ const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([
[ [
0, 0,
▲ Show 20 Lines • Show All 139 Lines • ▼ Show 20 Lines [
async () => { async () => {
await dbQuery( await dbQuery(
SQL` SQL`
ALTER TABLE uploads ALTER TABLE uploads
ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL, ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL,
ADD INDEX IF NOT EXISTS thread (thread); ADD INDEX IF NOT EXISTS thread (thread);
UPDATE uploads UPDATE uploads
SET thread = ( SET thread = (
SELECT thread FROM messages SELECT thread FROM messages
WHERE messages.id = uploads.container WHERE messages.id = uploads.container
); );
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[ [
16, 16,
async () => { async () => {
▲ Show 20 Lines • Show All 171 Lines • ▼ Show 20 Lines async () => {
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD UNIQUE KEY (name), ADD UNIQUE KEY (name),
ADD INDEX community_primary (community, \`primary\`); ADD INDEX community_primary (community, \`primary\`);
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[
32,
async () => {
await dbQuery(SQL`
UPDATE messages
SET target_message = JSON_VALUE(content, "$.sourceMessageID")
WHERE type = ${messageTypes.SIDEBAR_SOURCE};
`);
},
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines
View Options

landing/competitor-logo.react.js

// @flow // @flow
import fs from 'fs'; import fs from 'fs';
import { policyTypes } from 'lib/facts/policies.js'; import { policyTypes } from 'lib/facts/policies.js';
import { messageTypes } from 'lib/types/message-types.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { processMessagesInDBForSearch } from '../database/search-utils.js'; import { processMessagesInDBForSearch } from '../database/search-utils.js';
import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js'; import { updateRolesAndPermissionsForAllThreads } from '../updaters/thread-permission-updaters.js';
const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([ const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([
[ [
0, 0,
▲ Show 20 Lines • Show All 139 Lines • ▼ Show 20 Lines [
async () => { async () => {
await dbQuery( await dbQuery(
SQL` SQL`
ALTER TABLE uploads ALTER TABLE uploads
ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL, ADD COLUMN IF NOT EXISTS thread bigint(20) DEFAULT NULL,
ADD INDEX IF NOT EXISTS thread (thread); ADD INDEX IF NOT EXISTS thread (thread);
UPDATE uploads UPDATE uploads
SET thread = ( SET thread = (
SELECT thread FROM messages SELECT thread FROM messages
WHERE messages.id = uploads.container WHERE messages.id = uploads.container
); );
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[ [
16, 16,
async () => { async () => {
▲ Show 20 Lines • Show All 171 Lines • ▼ Show 20 Lines async () => {
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD UNIQUE KEY (name), ADD UNIQUE KEY (name),
ADD INDEX community_primary (community, \`primary\`); ADD INDEX community_primary (community, \`primary\`);
`, `,
{ multipleStatements: true }, { multipleStatements: true },
); );
}, },
], ],
[
32,
async () => {
await dbQuery(SQL`
UPDATE messages
SET target_message = JSON_VALUE(content, "$.sourceMessageID")
WHERE type = ${messageTypes.SIDEBAR_SOURCE};
`);
},
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines