[landing] introduce competitors type
ClosedPublic
Actions

Authored by ginsu on May 29 2023, 4:33 PM.

Details

Reviewers

atul
kamil

Commits

rCOMM93feef9ace86: [landing] introduce competitors type

Summary

As I was working on addressing some feedback to competitor feedback cards, I wanted to reuse the values of competitors as a type in the competitor card component and competitor logo component. This diff creates the shared type

Depends on D7904

Test Plan

flow, everything still works

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.May 29 2023, 4:33 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 4:33 PM

ginsu edited the summary of this revision. (Show Details)May 29 2023, 4:39 PM

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D7904: [landing] introduce signal competitor data.

ginsu added a child revision: D7905: [landing] introduce competitor feature card component.

Harbormaster completed remote builds in B19875: Diff 27231.May 29 2023, 4:51 PM

ginsu requested review of this revision.May 29 2023, 4:51 PM

atul accepted this revision.May 30 2023, 7:17 AM

This revision is now accepted and ready to land.May 30 2023, 7:17 AM

rebase before landing

Harbormaster completed remote builds in B21615: Diff 29655.Aug 8 2023, 12:58 PM

Closed by commit rCOMM93feef9ace86: [landing] introduce competitors type (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM93feef9ace86: [landing] introduce competitors type.

Revision Contents
Changeset List

Path

Size

landing/

competitor-data.js

12 lines

competitor-logo.react.js

3 lines

Diff 29655

View Options

landing/competitor-data.js