				// @flow

				import * as React from 'react';

				import { type SetState } from 'lib/types/hook-types';
				import { type RelationshipButton } from 'lib/types/relationship-types';
				import { type ThreadInfo } from 'lib/types/thread-types';
				import type { UserInfo } from 'lib/types/user-types';

				import ThreadSettingsRelationshipButton from './thread-settings-relationship-button.react';
				import css from './thread-settings-relationship-tab.css';

				type Props = {
				+threadSettingsOperationInProgress: boolean,
				+threadInfo: ThreadInfo,
				tomekUnsubmitted Not Done Inline Actions These props aren't used. Shouldn't this give a warning? tomek: These props aren't used. Shouldn't this give a warning?
				jacekAuthorUnsubmitted Done Inline Actions Interesting. I thought flow should indicate warning for such variables. jacek: Interesting. I thought flow should indicate warning for such variables.
				ashoatUnsubmitted Not Done Inline Actions There can be a good reason for having a prop that you never use: to force the component to rerender. For instance, we do something similar here ashoat: There can be a good reason for having a prop that you never use: to force the component to…
				+setErrorMessage: SetState<string>,
				+relationshipButtons: $ReadOnlyArray<RelationshipButton>,
				+otherUserInfo: UserInfo,
				};

				function ThreadSettingsRelationshipTab(props: Props): React.Node {
				const { relationshipButtons, otherUserInfo, setErrorMessage } = props;
				const buttons = React.useMemo(() => {
				return relationshipButtons.map(action => {
				return (
				<ThreadSettingsRelationshipButton
				key={action}
				relationshipButton={action}
				otherUserInfo={otherUserInfo}
				setErrorMessage={setErrorMessage}
				tomekUnsubmitted Not Done Inline Actions In `ThreadSettingsRelationshipButton` `setErrorMessage` is `string => void` but here we use `SetState<string>`. Is flow ok with that? Is there a good reason for having different types? tomek: In `ThreadSettingsRelationshipButton` `setErrorMessage` is `string => void` but here we use…
				jacekAuthorUnsubmitted Done Inline Actions Flow is ok here. I'll replace the type in `...Button` with `SetState<string>` jacek: Flow is ok here. I'll replace the type in `...Button` with `SetState<string>`
				/>
				);
				});
				}, [otherUserInfo, relationshipButtons, setErrorMessage]);
				return <div className={css.container}>{buttons}</div>;
				}

				export default ThreadSettingsRelationshipTab;

[web] Indicate success via `saveAvatarButton` on successClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27980

web/avatars/emoji-avatar-selection-modal.react.js

[web] Indicate success via `saveAvatarButton` on success
ClosedPublic
Actions

Revision Contents
Changeset List