[web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 4:04 PM.

Details

Reviewers

ashoat
ginsu
rohan

Commits

rCOMMdebbfe636078: [web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab

Summary

Separate Emoji and Color into separate tabs.

NOTE: Layout/Styling will be handled separately.

WARNING: Took some liberties here with styling to unblock myself since emoji selection part of this modal wasn't part of designs (https://blob.sh/84e83d.png). Kept things as simple as possible, happy to iterate on this further. (cc @ashoat, @ted)

Depends on D8286

Test Plan

Looks (and continues to work) as expected:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 21 2023, 4:04 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 4:04 PM

atul published this revision for review.Jun 21 2023, 4:09 PM

atul edited the summary of this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B20414: Diff 27986.Jun 21 2023, 4:22 PM

atul added a child revision: D8289: [web] Style "Emoji" tab of `EmojiAvatarSelectionModal`.Jun 21 2023, 4:26 PM

ginsu accepted this revision.Jun 22 2023, 4:01 PM

This revision is now accepted and ready to land.Jun 22 2023, 4:01 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM

Closed by commit rCOMMdebbfe636078: [web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMdebbfe636078: [web] Split `EmojiAvatarSelectionModal` into "Emoji" and "Color" tab.

Harbormaster completed remote builds in B20497: Diff 28083.Jun 23 2023, 2:54 PM

Revision Contents
Changeset List

Path

Size

web/

avatars/

emoji-avatar-selection-modal.css

5 lines

emoji-avatar-selection-modal.react.js

53 lines

Diff 27986

View Options

web/avatars/emoji-avatar-selection-modal.css