To improve debugging the addon, allow for it to log to console.
Previously the logging statements would never be outputted.
Depends on D8402
Paths
| Differential D8403 Authored by • jon on Jun 30 2023, 3:37 PM.
Details
Summary To improve debugging the addon, allow for it to log to console. Depends on D8402 Test Plan cd keyserver RUST_LOG=debug yarn dev # assert debugging output from aws_sdk
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptJun 30 2023, 3:37 PM2023-06-30 15:37:14 (UTC-7) Harbormaster completed remote builds in B20663: Diff 28319.Jun 30 2023, 4:11 PM2023-06-30 16:11:57 (UTC-7) This revision is now accepted and ready to land.Jun 30 2023, 11:14 PM2023-06-30 23:14:30 (UTC-7) This revision was landed with ongoing or failed builds.Jul 16 2023, 7:39 PM2023-07-16 19:39:54 (UTC-7) Closed by commit rCOMM2961e68cfce7: [Keyserver/rust] Enable logging of rust addon (authored by • jon). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B20958: Diff 28714.Jul 17 2023, 1:15 AM2023-07-17 01:15:24 (UTC-7)
Revision Contents
Diff 28319 keyserver/addons/rust-node-addon/Cargo.lock
keyserver/addons/rust-node-addon/Cargo.toml
keyserver/addons/rust-node-addon/rust-binding-types.js
keyserver/addons/rust-node-addon/src/identity_client/login.rs
|
Do we really want to make this change in production? Should we consider gating it on isStaffRelease?