Page MenuHomePhabricator
Differential D8557

[web] rework storage engine tests to use CommQueryExecutor
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 6:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 4:58 AM
Unknown Object (File)
Thu, Mar 27, 12:12 AM
Unknown Object (File)
Tue, Mar 25, 6:05 AM
Unknown Object (File)
Mon, Mar 24, 12:49 AM
Unknown Object (File)
Sat, Mar 15, 6:10 PM
Unknown Object (File)
Wed, Mar 12, 10:21 PM
Unknown Object (File)
Tue, Mar 11, 5:23 PM
Unknown Object (File)
Tue, Mar 11, 10:41 AM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMMba914f510cfe: [web] rework storage engine tests to use CommQueryExecutor
Summary

Updates test to new module

Depends on D8556

Test Plan

Run tests

Diff Detail

Repository
rCOMM Comm
Branch
wasm-publish
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 6:58 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 6:58 AM
kamil added a child revision: D8558: [web] rework database module tests to use CommQueryExecutor.Jul 19 2023, 7:00 AM
Harbormaster completed remote builds in B21036: Diff 28832.Jul 19 2023, 7:35 AM
kamil published this revision for review.Jul 19 2023, 9:07 AM
kamil mentioned this in D8472: [native] add entity and methods for redux-persist storage.Jul 20 2023, 7:07 AM
michal accepted this revision.Jul 21 2023, 6:23 AM
michal added inline comments.
web/database/queries/storage-engine-queries.test.js
42

Shouldn't we clear this item after the test ends?

This revision is now accepted and ready to land.Jul 21 2023, 6:23 AM
kamil mentioned this in rCOMM6d72d08d6592: [native] add entity and methods for redux-persist storage.Jul 21 2023, 7:26 AM
kamil removed a child revision: D8558: [web] rework database module tests to use CommQueryExecutor.Jul 25 2023, 2:05 AM
kamil updated this revision to Diff 29005.Jul 25 2023, 2:09 AM

rebase

kamil added a child revision: D8560: [web] switch code from `sql.js` API to `.wasm` database module.Jul 25 2023, 2:14 AM
kamil added inline comments.Jul 25 2023, 2:22 AM
web/database/queries/storage-engine-queries.test.js
42

https://phab.comm.dev/D8555?id=28830#inline-55238

Harbormaster completed remote builds in B21172: Diff 29005.Jul 25 2023, 3:05 AM
Closed by commit rCOMMba914f510cfe: [web] rework storage engine tests to use CommQueryExecutor (authored by kamil). · Explain WhyJul 27 2023, 5:40 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMba914f510cfe: [web] rework storage engine tests to use CommQueryExecutor.

Revision Contents
Changeset List

PathSize
web/
database/
queries/
52 lines

Diff 28832

View Options

web/database/queries/storage-engine-queries.test.js

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<RootNavigator /> <RootNavigator />
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider initialMetrics={initialWindowMetrics}>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider persistence={filesystemMediaCache}> <MediaCacheProvider persistence={filesystemMediaCache}>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<ChatContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<Socket <Socket
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</MessageSearchProvider> </MessageSearchProvider>
</ChatContextProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
Show All 25 Lines